Skip to content

chore: Tune code scanning tools to reduce noise #231

@joshsmithxrm

Description

@joshsmithxrm

Summary

Code scanning tools are generating excessive noise on PRs. Need to tune or disable unhelpful rules.

Current Noise (from PR #227)

CodeQL (github-advanced-security)

  • "Generic catch clause" - flags catch (Exception ex) (14+ instances)
  • "Missed opportunity to use Where" - LINQ style suggestion

Copilot

  • "This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'"

Gemini

  • Provides useful feedback (medium priority issues) - keep enabled

Actions

  • Disable CodeQL "Missed opportunity to use Where" rule (cs/linq-use-where)
  • Disable Copilot LINQ style suggestions if possible
  • Review "Generic catch clause" warnings - some valid, some intentional
  • Document decisions in .github/CODE_SCANNING.md

Context

Per ADR-0024 (pending), we prefer explicit foreach over LINQ. These style suggestions contradict that decision.


🤖 Generated with Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions