Skip to content

Commit 5f9f456

Browse files
committed
minor #15144 [Finder] Fix PHPUnit param order (Dave Hulbert)
This PR was merged into the 2.7 branch. Discussion ---------- [Finder] Fix PHPUnit param order | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Fairly cosmetic but it confused me for a while when I broke tests and PHPUnit said something like --- Expected +++ Actual @@ @@ -'/^(?=[^\.])x\.[^/]*$/' +'/^\.[^/]*$/' Looks like 2.7 is the earliest this can be merged into. Commits ------- 3b1d4cd Fix param order of assertEquals (expected, actual) in test for Finder\Glob
2 parents 210202f + 3b1d4cd commit 5f9f456

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

Tests/GlobTest.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,10 @@
1515

1616
class GlobTest extends \PHPUnit_Framework_TestCase
1717
{
18-
1918
public function testGlobToRegexDelimiters()
2019
{
21-
$this->assertEquals(Glob::toRegex('.*'), '#^\.[^/]*$#');
22-
$this->assertEquals(Glob::toRegex('.*', true, true, ''), '^\.[^/]*$');
23-
$this->assertEquals(Glob::toRegex('.*', true, true, '/'), '/^\.[^/]*$/');
20+
$this->assertEquals('#^\.[^/]*$#', Glob::toRegex('.*'));
21+
$this->assertEquals('^\.[^/]*$', Glob::toRegex('.*', true, true, ''));
22+
$this->assertEquals('/^\.[^/]*$/', Glob::toRegex('.*', true, true, '/'));
2423
}
2524
}

0 commit comments

Comments
 (0)