Checkstyle

Author: joshua-adams-1

server/src/main/java/org/elasticsearch/cluster/coordination/Coordinator.java

@@ -674,7 +674,7 @@ public void onResponse(Releasable response) {
             public void onFailure(Exception e) {
                 // The failure of the first node-join publication does not imply that the join failed,
                 // because it may be retried and eventually succeed
-                if (!applierState.nodes().nodeExists(joinRequest.getSourceNode())) {
+                if (applierState.nodes().nodeExists(joinRequest.getSourceNode()) == false) {
                     logger.warn(
                         () -> format(
                             "received join request from [%s] but could not connect back to the joining node",

server/src/test/java/org/elasticsearch/cluster/coordination/CoordinatorTests.java

@@ -1492,18 +1492,13 @@ public void testDoesNotReportConnectBackProblemsDuringJoiningIfNodeIsInClusterSt
 
             logger.info("--> removed [{}] but adding to master's cluster state", partitionedNode);
             final ClusterNode leader = cluster.getAnyLeader();
-            leader.submitUpdateTask("updating cluster state",
-                cs -> {
-                    ClusterState cs2 = ClusterState.builder(cs)
-                        .nodes(DiscoveryNodes.builder(cs.nodes())
-                            .add(partitionedNode.getLocalNode())
-                            .build())
-                        .build();
-                    // Insert breakpoint here
-                    return cs2;
-                },
-                (e) -> {}
-            );
+            leader.submitUpdateTask("updating cluster state", cs -> {
+                ClusterState cs2 = ClusterState.builder(cs)
+                    .nodes(DiscoveryNodes.builder(cs.nodes()).add(partitionedNode.getLocalNode()).build())
+                    .build();
+                // Insert breakpoint here
+                return cs2;
+            }, (e) -> {});
 
             logger.info("--> healing [{}] but blocking handshakes", partitionedNode);
             partitionedNode.heal();