Fix ClusterParser namespace filtering bug (fluent#1778)

ClusterParsers and ClusterMultilineParsers are cluster-scoped resources
and should not be filtered by namespace. This bug was introduced in
commit 30cd0c3 (PR fluent#1708) where the code was refactored to use a
listNamespacedResources helper function that incorrectly added namespace
filtering for cluster-scoped resources.

This caused ClusterParsers referenced from namespace-scoped Filters to
not be generated in parsers.conf with their hash-suffixed names, leading
to fluent-bit pods crashlooping with 'requested parser not found' errors.

The fix:
1. Changes the function to use listClusterResources (which doesn't filter
   by namespace) for ClusterParsers and ClusterMultilineParsers.
2. Renames ListNamespacedResources to ListFluentBitConfigResources to
   better reflect that it lists both namespaced and cluster-scoped
   resources needed by a FluentBitConfig.

Note: The original code (pre-refactor) also had a bug where
ClusterMultilineParsers were incorrectly filtered by namespace.

Fixes fluent#1778

Signed-off-by: Josh Baird <[email protected]>

Author: joshuabaird

controllers/fluentbitconfig_controller.go

@@ -245,7 +245,7 @@ func (r *FluentBitConfigReconciler) processNamespacedFluentBitCfgs(
 	for _, cfg := range nsCfgs.Items {
 		filterList, outputList, parserList,
 			clusterParserList, multilineParsersList,
-			clusterMultilineParsersList, err := r.ListNamespacedResources(
+			clusterMultilineParsersList, err := r.ListFluentBitConfigResources(
 			ctx, cfg,
 		)
 		if err != nil {
@@ -299,7 +299,9 @@ func listNamespacedResources[T client.ObjectList](
 	return nil
 }
 
-func (r *FluentBitConfigReconciler) ListNamespacedResources(
+// ListFluentBitConfigResources lists all resources (both namespaced and cluster-scoped)
+// needed by the given FluentBitConfig.
+func (r *FluentBitConfigReconciler) ListFluentBitConfigResources(
 	ctx context.Context, cfg fluentbitv1alpha2.FluentBitConfig,
 ) (
 	fluentbitv1alpha2.FilterList,
@@ -324,13 +326,7 @@ func (r *FluentBitConfigReconciler) ListNamespacedResources(
 		return filters, outputs, parsers, clusterParsers, multipleParsers, clusterMultipleParsers, err
 	}
 
-	if err := listNamespacedResources(
-		ctx,
-		r.Client,
-		&clusterParsers,
-		cfg.Namespace,
-		&cfg.Spec.ClusterParserSelector,
-	); err != nil {
+	if err := listClusterResources(ctx, r.Client, &cfg.Spec.ClusterParserSelector, &clusterParsers); err != nil {
 		return filters, outputs, parsers, clusterParsers, multipleParsers, clusterMultipleParsers, err
 	}
 
@@ -344,13 +340,7 @@ func (r *FluentBitConfigReconciler) ListNamespacedResources(
 		return filters, outputs, parsers, clusterParsers, multipleParsers, clusterMultipleParsers, err
 	}
 
-	if err := listNamespacedResources(
-		ctx,
-		r.Client,
-		&clusterMultipleParsers,
-		cfg.Namespace,
-		&cfg.Spec.ClusterMultilineParserSelector,
-	); err != nil {
+	if err := listClusterResources(ctx, r.Client, &cfg.Spec.ClusterMultilineParserSelector, &clusterMultipleParsers); err != nil {
 		return filters, outputs, parsers, clusterParsers, multipleParsers, clusterMultipleParsers, err
 	}