change render_props arg from NodeList to Component (#139)

Author: joshuadavidthomas

CHANGELOG.md

@@ -22,6 +22,7 @@ and this project attempts to adhere to [Semantic Versioning](https://semver.org/
 
 - **Internal**: Refactored slot handling logic by moving slot processing from `BirdNode` to `BoundComponent`.
 - **Internal**: Simplified component context management in `BirdNode` by offloading context prep to `BoundComponent`.
+- **Internal**: Refactored prop rendering in `Params` to take a `Component` instance instead of the raw `NodeList`.
 
 ### Removed
 

src/django_bird/components.py

@@ -131,7 +131,7 @@ def render(self, context: Context):
             ]
             self.params.attrs.extend(data_attrs)
 
-        props = self.params.render_props(self.component.nodelist, context)
+        props = self.params.render_props(self.component, context)
         attrs = self.params.render_attrs(context)
         slots = self.fill_slots(context)
 

src/django_bird/params.py

@@ -2,16 +2,19 @@
 
 from dataclasses import dataclass
 from dataclasses import field
+from typing import TYPE_CHECKING
 from typing import Any
 
 from django import template
-from django.template.base import NodeList
 from django.template.context import Context
 from django.utils.safestring import SafeString
 from django.utils.safestring import mark_safe
 
 from .templatetags.tags.prop import PropNode
 
+if TYPE_CHECKING:
+    from django_bird.components import Component
+
 
 @dataclass
 class Params:
@@ -23,13 +26,13 @@ def with_attrs(cls, attrs: list[Param] | None) -> Params:
         """Create a Params instance with a copy of the provided attrs."""
         return cls(attrs=attrs.copy() if attrs is not None else [], props=[])
 
-    def render_props(self, nodelist: NodeList | None, context: Context):
-        if nodelist is None:
+    def render_props(self, component: Component, context: Context):
+        if component.nodelist is None:
             return
 
         attrs_to_remove = set()
 
-        for node in nodelist:
+        for node in component.nodelist:
             if not isinstance(node, PropNode):
                 continue
 

tests/test_params.py

@@ -2,10 +2,12 @@
 
 import pytest
 
+from django_bird.components import Component
 from django_bird.params import Param
 from django_bird.params import Params
 from django_bird.params import Value
-from django_bird.templatetags.tags.prop import PropNode
+
+from .utils import TestComponent
 
 
 class TestValue:
@@ -141,39 +143,39 @@ def test_from_bit(self, bit, expected):
 
 class TestParams:
     @pytest.mark.parametrize(
-        "params,nodelist,context,expected_props,expected_attrs",
+        "params,test_component,context,expected_props,expected_attrs",
         [
             (
                 Params(attrs=[Param(name="class", value=Value(None))]),
-                [PropNode(name="class", default="btn", attrs=[])],
+                TestComponent(name="test", content="{% bird:prop class='btn' %}"),
                 {},
                 {"class": "btn"},
                 [],
             ),
             (
                 Params(attrs=[Param(name="class", value=Value("btn", quoted=False))]),
-                [PropNode(name="class", default=None, attrs=[])],
+                TestComponent(name="test", content="{% bird:prop class %}"),
                 {},
                 {"class": "btn"},
                 [],
             ),
             (
                 Params(attrs=[Param(name="class", value=Value("btn", quoted=False))]),
-                None,
+                TestComponent(name="test", content=""),
+                {},
                 {},
-                None,
                 [Param(name="class", value=Value("btn", quoted=False))],
             ),
             (
                 Params(attrs=[Param(name="class", value=Value("static", quoted=True))]),
-                [PropNode(name="class", default=None, attrs=[])],
+                TestComponent(name="test", content="{% bird:prop class %}"),
                 {"static": "dynamic"},
                 {"class": "static"},
                 [],
             ),
             (
                 Params(attrs=[Param(name="class", value=Value("var", quoted=False))]),
-                [PropNode(name="class", default=None, attrs=[])],
+                TestComponent(name="test", content="{% bird:prop class %}"),
                 {"var": "dynamic"},
                 {"class": "dynamic"},
                 [],
@@ -182,7 +184,7 @@ class TestParams:
                 Params(
                     attrs=[Param(name="class", value=Value("undefined", quoted=False))]
                 ),
-                [PropNode(name="class", default=None, attrs=[])],
+                TestComponent(name="test", content="{% bird:prop class %}"),
                 {},
                 {"class": "undefined"},
                 [],
@@ -191,17 +193,25 @@ class TestParams:
                 Params(
                     attrs=[Param(name="class", value=Value("user.name", quoted=False))]
                 ),
-                [PropNode(name="class", default=None, attrs=[])],
+                TestComponent(name="test", content="{% bird:prop class %}"),
                 {},
                 {"class": "user.name"},
                 [],
             ),
         ],
     )
     def test_render_props(
-        self, params, nodelist, context, expected_props, expected_attrs
+        self,
+        params,
+        test_component,
+        context,
+        expected_props,
+        expected_attrs,
+        templates_dir,
     ):
-        assert params.render_props(nodelist, context) == expected_props
+        test_component.create(templates_dir)
+        component = Component.from_name(test_component.name)
+        assert params.render_props(component, context) == expected_props
         assert params.attrs == expected_attrs
 
     @pytest.mark.parametrize(