fix asset view (#114)

Author: joshuadavidthomas

CHANGELOG.md

@@ -18,6 +18,10 @@ and this project attempts to adhere to [Semantic Versioning](https://semver.org/
 
 ## [Unreleased]
 
+### Fixed
+
+- Fixed asset serving view to properly stream files using `FileResponse` instead of reading file contents directly.
+
 ## [0.10.0]
 
 ### Added

src/django_bird/views.py

@@ -28,7 +28,6 @@ def asset_view(request: HttpRequest, component_name: str, asset_filename: str):
     if not asset or not asset.path.exists():
         raise Http404("Asset not found")
 
-    with open(asset.path, "rb") as f:
-        content = f.read()
+    file = open(asset.path, "rb")
 
-    return FileResponse(content, content_type=asset.type.content_type)
+    return FileResponse(file, content_type=asset.type.content_type)

tests/test_views.py

@@ -72,6 +72,10 @@ def test_get_css(templates_dir, client):
     assert response.status_code == HTTPStatus.OK
     assert response["Content-Type"] == "text/css"
 
+    content = b"".join(response.streaming_content).decode()
+
+    assert content == ".button { color: blue; }"
+
 
 def test_get_js(templates_dir, client):
     button = TestComponent(name="button", content="<button>Click me</button>").create(
@@ -86,6 +90,10 @@ def test_get_js(templates_dir, client):
     assert response.status_code == HTTPStatus.OK
     assert response["Content-Type"] == "application/javascript"
 
+    content = b"".join(response.streaming_content).decode()
+
+    assert content == "console.log('button');"
+
 
 def test_get_invalid_type(templates_dir, client):
     button = TestComponent(name="button", content="<button>Click me</button>").create(