refactor Params class constructor to from_node (#157)

Author: joshuadavidthomas

src/django_bird/components.py

@@ -47,7 +47,7 @@ def get_asset(self, asset_filename: str) -> Asset | None:
         return None
 
     def get_bound_component(self, node: BirdNode):
-        params = Params.with_attrs(node.attrs)
+        params = Params.from_node(node)
         return BoundComponent(component=self, params=params, nodelist=node.nodelist)
 
     @property

src/django_bird/params.py

@@ -14,18 +14,14 @@
 
 if TYPE_CHECKING:
     from django_bird.components import Component
+    from django_bird.templatetags.tags.bird import BirdNode
 
 
 @dataclass
 class Params:
     attrs: list[Param] = field(default_factory=list)
     props: list[Param] = field(default_factory=list)
 
-    @classmethod
-    def with_attrs(cls, attrs: list[Param] | None) -> Params:
-        """Create a Params instance with a copy of the provided attrs."""
-        return cls(attrs=attrs.copy() if attrs is not None else [], props=[])
-
     def render_props(self, component: Component, context: Context):
         if component.nodelist is None:
             return
@@ -56,6 +52,10 @@ def render_attrs(self, context: Context) -> SafeString:
         rendered = " ".join(attr.render_attr(context) for attr in self.attrs)
         return mark_safe(rendered)
 
+    @classmethod
+    def from_node(cls, node: BirdNode) -> Params:
+        return cls(attrs=node.attrs.copy(), props=[])
+
 
 @dataclass
 class Param:
@@ -64,9 +64,9 @@ class Param:
 
     def render_attr(self, context: Context) -> str:
         value = self.value.resolve(context)
-        name = self.name.replace("_", "-")
         if value is None:
             return ""
+        name = self.name.replace("_", "-")
         if value is True:
             return name
         return f'{name}="{value}"'

tests/test_params.py

@@ -6,6 +6,7 @@
 from django_bird.params import Param
 from django_bird.params import Params
 from django_bird.params import Value
+from django_bird.templatetags.tags.bird import BirdNode
 
 from .utils import TestComponent
 
@@ -305,5 +306,6 @@ def test_render_attrs(self, params, context, expected):
             ),
         ],
     )
-    def test_with_attrs(self, attrs, expected):
-        assert Params.with_attrs(attrs) == expected
+    def test_from_node(self, attrs, expected):
+        node = BirdNode(name="test", attrs=attrs, nodelist=None)
+        assert Params.from_node(node) == expected