Modify component name parsing to preserve literal strings (#107)

Author: joshuadavidthomas

CHANGELOG.md

@@ -18,6 +18,10 @@ and this project attempts to adhere to [Semantic Versioning](https://semver.org/
 
 ## [Unreleased]
 
+### Changed
+
+- Changed component name handling to preserve quotes, allowing literal string names to bypass dynamic resolution (e.g. `{% bird "button" %}` will always use "button" even if `button` exists in the context).
+
 ## [0.9.1]
 
 ### Fixed

docs/naming.md

@@ -49,17 +49,24 @@ templates/
 
 See [Organizing Components](organization.md) for detailed directory structure examples.
 
-## Dynamic Names
+## Dynamic vs Literal Names
 
-Component names can be dynamic, using template variables:
+Component names can be either dynamic or literal:
 
 ```htmldjango
+{# Dynamic name - resolves from context #}
 {% with component_name="icon.arrow-down" %}
     {% bird component_name / %}
 {% endwith %}
+
+{# Literal name - always uses "button" #}
+{% bird "button" / %}
+{% bird 'button' / %}
 ```
 
-This is particularly useful when the component choice needs to be determined at runtime in your Django view.
+When using an unquoted name, django-bird will attempt to resolve it from the template context. This is useful when the component choice needs to be determined at runtime in your Django view.
+
+Using quoted names (single or double quotes) ensures the literal string is used as the component name, bypassing context resolution. This is useful when you want to ensure a specific component is always used, even if a variable with the same name exists in the context.
 
 ## Template Resolution
 

src/django_bird/templatetags/tags/bird.py

@@ -24,7 +24,10 @@
 
 def do_bird(parser: Parser, token: Token) -> BirdNode:
     bits = token.split_contents()
-    name = parse_bird_name(bits)
+    if len(bits) == 1:
+        msg = f"{TAG} tag requires at least one argument"
+        raise template.TemplateSyntaxError(msg)
+    name = bits[1]
     attrs = []
     only = False
 
@@ -42,17 +45,6 @@ def do_bird(parser: Parser, token: Token) -> BirdNode:
     return BirdNode(name, attrs, nodelist, only)
 
 
-def parse_bird_name(bits: TagBits) -> str:
-    if len(bits) == 1:
-        msg = f"{TAG} tag requires at least one argument"
-        raise template.TemplateSyntaxError(msg)
-
-    # {% bird name %}
-    # {% bird 'name' %}
-    # {% bird "name" %}
-    return bits[1].strip("'\"")
-
-
 def parse_nodelist(bits: TagBits, parser: Parser) -> NodeList | None:
     # self-closing tag
     # {% bird name / %}

tests/templatetags/test_bird.py

@@ -27,8 +27,8 @@ class TestTagParsing:
         "name,expected",
         [
             ("button", "button"),
-            ("'button'", "button"),
-            ('"button"', "button"),
+            ("'button'", "'button'"),
+            ('"button"', '"button"'),
             ("button.label", "button.label"),
         ],
     )
@@ -202,7 +202,7 @@ def test_nested_name_templatetag(self, templates_dir, normalize_whitespace):
                     name="button",
                     content="""
                         <button>
-                            Click me
+                            {{ slot }}
                         </button>
                     """,
                 ),
@@ -221,7 +221,7 @@ def test_nested_name_templatetag(self, templates_dir, normalize_whitespace):
                     name="button",
                     content="""
                         <button>
-                            Click me
+                            {{ slot }}
                         </button>
                     """,
                 ),
@@ -233,6 +233,24 @@ def test_nested_name_templatetag(self, templates_dir, normalize_whitespace):
                 template_context={"dynamic-name": "button"},
                 expected="<button>Click me</button>",
             ),
+            TestComponentCase(
+                description="Quoted component name should not be dynamic",
+                component=TestComponent(
+                    name="button",
+                    content="""
+                        <button>
+                            {{ slot }}
+                        </button>
+                    """,
+                ),
+                template_content="""
+                    {% bird "button" %}
+                        Click me
+                    {% endbird %}
+                """,
+                template_context={"button": "dynamic_name"},
+                expected="<button>Click me</button>",
+            ),
         ],
         ids=lambda x: x.description,
     )
@@ -248,6 +266,32 @@ def test_dynamic_name_template_context_templatetag(
 
         assert normalize_whitespace(rendered) == test_case.expected
 
+    def test_dynamic_name_with_string(self, templates_dir, normalize_whitespace):
+        button = TestComponent(
+            name="button",
+            content="""
+                <button>
+                    {{ slot }}
+                </button>
+            """,
+        )
+        not_button = TestComponent(
+            name="not_button",
+            content="""
+                <div>
+                    {{ slot }}
+                </div>
+            """,
+        )
+        button.create(templates_dir)
+        not_button.create(templates_dir)
+
+        template = Template("{% bird 'button' %}Click me{% endbird %}")
+        rendered = template.render(Context({"button": "not_button"}))
+
+        assert normalize_whitespace(rendered) == "<button>Click me</button>"
+        assert normalize_whitespace(rendered) != "<div>Click me</div>"
+
     def test_nonexistent_name_templatetag(self, templates_dir):
         template = Template("{% bird nonexistent %}Content{% endbird %}")