add tests for refresh and adjust fail floor for coverage

Author: joshuadavidthomas

noxfile.py

@@ -115,6 +115,8 @@ def coverage(session):
             for arg in session.posargs:
                 args.extend(arg.split(" "))
             command.extend(args)
+        if "--integration" not in command:
+            command.append("--cov-fail-under=99")
         session.run(*command)
     finally:
         # 0 -> OK

tests/test_models.py

@@ -1,9 +1,13 @@
 from __future__ import annotations
 
 import datetime
+from unittest.mock import MagicMock
 
 import pytest
 from asgiref.sync import sync_to_async
+from cryptography.hazmat.backends import default_backend
+from cryptography.hazmat.primitives import serialization
+from cryptography.hazmat.primitives.asymmetric import rsa
 from django.utils import timezone
 from gidgethub import sansio
 from model_bakery import baker
@@ -27,6 +31,21 @@ def _create_event(data, event):
     return _create_event
 
 
+@pytest.fixture
+def private_key():
+    private_key = rsa.generate_private_key(
+        public_exponent=65537, key_size=2048, backend=default_backend()
+    )
+
+    pem = private_key.private_bytes(
+        encoding=serialization.Encoding.PEM,
+        format=serialization.PrivateFormat.PKCS8,
+        encryption_algorithm=serialization.NoEncryption(),
+    )
+
+    return pem.decode("utf-8")
+
+
 class TestEventLogManager:
     @pytest.mark.asyncio
     async def test_acreate_from_event(self, create_event):
@@ -244,9 +263,42 @@ def test_get_gh_client(self, installation):
         assert isinstance(client, AsyncGitHubAPI)
         assert client.installation_id == installation.installation_id
 
+    @pytest.mark.parametrize("account_type", ["org", "user"])
     @pytest.mark.asyncio
-    async def test_arefresh_from_gh(self): ...
-    def test_refresh_from_gh(self): ...
+    async def test_arefresh_from_gh(
+        self,
+        account_type,
+        private_key,
+        ainstallation,
+        get_mock_github_api,
+        override_app_settings,
+    ):
+        installation = await ainstallation
+
+        mock_github_api = get_mock_github_api({"foo": "bar"})
+        installation.get_gh_client = MagicMock(return_value=mock_github_api)
+
+        with override_app_settings(PRIVATE_KEY=private_key):
+            await installation.arefresh_from_gh(account_type, "test")
+
+        assert installation.data == {"foo": "bar"}
+
+    @pytest.mark.parametrize("account_type", ["org", "user"])
+    def test_refresh_from_gh(
+        self,
+        account_type,
+        private_key,
+        installation,
+        get_mock_github_api,
+        override_app_settings,
+    ):
+        mock_github_api = get_mock_github_api({"foo": "bar"})
+        installation.get_gh_client = MagicMock(return_value=mock_github_api)
+
+        with override_app_settings(PRIVATE_KEY=private_key):
+            installation.refresh_from_gh(account_type, "test")
+
+        assert installation.data == {"foo": "bar"}
 
     def test_refresh_from_gh_invalid_account_type(self, installation):
         with pytest.raises(ValueError):