@@ -186,7 +186,6 @@ async def test_csrf_exempt(self, webhook_request):
186186 assert response .status_code != HTTPStatus .FORBIDDEN
187187
188188 async def test_event_log_created (self , webhook_request , aregister_webhook_event ):
189- # Register a handler for the webhook event
190189 aregister_webhook_event ("push" )
191190 request = webhook_request (event_type = "push" )
192191 view = AsyncWebhookView ()
@@ -246,11 +245,9 @@ async def test_router_dispatch_unhandled_event(
246245 aregister_webhook_event ("push" , should_fail = True )
247246 view = AsyncWebhookView ()
248247
249- # Create event directly, bypassing webhook validation
250248 data = {"action" : "opened" }
251249 event = sansio .Event (data , event = "issues" , delivery_id = "12345" )
252250
253- # Mock the get_event method to return our event
254251 monkeypatch .setattr (view , "get_event" , lambda request : event )
255252
256253 response = await view .post (None )
@@ -262,49 +259,37 @@ async def test_unhandled_event_log_creation_with_log_all(
262259 self , monkeypatch , aregister_webhook_event , override_app_settings
263260 ):
264261 with override_app_settings (LOG_ALL_EVENTS = True ):
265- # Register handler for "push" but send "issues" event
266262 aregister_webhook_event ("push" , should_fail = True )
267263 view = AsyncWebhookView ()
268264
269- # Create event directly, bypassing webhook validation
270265 data = {"action" : "opened" }
271266 event = sansio .Event (data , event = "issues" , delivery_id = "12345" )
272267
273- # Mock the get_event method to return our event
274268 monkeypatch .setattr (view , "get_event" , lambda request : event )
275269
276- # Get count before
277270 count_before = await EventLog .objects .acount ()
278271
279- # Process request (with a dummy request)
280272 await view .post (None )
281273
282- # Verify event log is created when LOG_ALL_EVENTS=True
283274 count_after = await EventLog .objects .acount ()
284275 assert count_after - count_before == 1
285276
286277 async def test_unhandled_event_log_creation_without_log_all (
287278 self , monkeypatch , aregister_webhook_event , override_app_settings
288279 ):
289280 with override_app_settings (LOG_ALL_EVENTS = False ):
290- # Register handler for "push" but send "issues" event
291281 aregister_webhook_event ("push" , should_fail = True )
292282 view = AsyncWebhookView ()
293283
294- # Create event directly, bypassing webhook validation
295284 data = {"action" : "opened" }
296285 event = sansio .Event (data , event = "issues" , delivery_id = "12345" )
297286
298- # Mock the get_event method to return our event
299287 monkeypatch .setattr (view , "get_event" , lambda request : event )
300288
301- # Get count before
302289 count_before = await EventLog .objects .acount ()
303290
304- # Process request (with a dummy request)
305291 await view .post (None )
306292
307- # Verify event log is not created when LOG_ALL_EVENTS=False
308293 count_after = await EventLog .objects .acount ()
309294 assert count_after - count_before == 0
310295
@@ -328,7 +313,6 @@ def test_csrf_exempt(self, webhook_request):
328313 assert response .status_code != HTTPStatus .FORBIDDEN
329314
330315 def test_event_log_created (self , webhook_request , register_webhook_event ):
331- # Register a handler for the webhook event
332316 register_webhook_event ("push" )
333317 request = webhook_request (event_type = "push" )
334318 view = SyncWebhookView ()
@@ -374,11 +358,9 @@ def test_router_dispatch_unhandled_event(
374358 register_webhook_event ("push" , should_fail = True )
375359 view = SyncWebhookView ()
376360
377- # Create event directly, bypassing webhook validation
378361 data = {"action" : "opened" }
379362 event = sansio .Event (data , event = "issues" , delivery_id = "12345" )
380363
381- # Mock the get_event method to return our event
382364 monkeypatch .setattr (view , "get_event" , lambda request : event )
383365
384366 response = view .post (None )
@@ -390,48 +372,36 @@ def test_unhandled_event_log_creation_with_log_all(
390372 self , monkeypatch , register_webhook_event , override_app_settings
391373 ):
392374 with override_app_settings (LOG_ALL_EVENTS = True ):
393- # Register handler for "push" but send "issues" event
394375 register_webhook_event ("push" , should_fail = True )
395376 view = SyncWebhookView ()
396377
397- # Create event directly, bypassing webhook validation
398378 data = {"action" : "opened" }
399379 event = sansio .Event (data , event = "issues" , delivery_id = "12345" )
400380
401- # Mock the get_event method to return our event
402381 monkeypatch .setattr (view , "get_event" , lambda request : event )
403382
404- # Get count before
405383 count_before = EventLog .objects .count ()
406384
407- # Process request (with a dummy request)
408385 view .post (None )
409386
410- # Verify event log is created when LOG_ALL_EVENTS=True
411387 count_after = EventLog .objects .count ()
412388 assert count_after - count_before == 1
413389
414390 def test_unhandled_event_log_creation_without_log_all (
415391 self , monkeypatch , register_webhook_event , override_app_settings
416392 ):
417393 with override_app_settings (LOG_ALL_EVENTS = False ):
418- # Register handler for "push" but send "issues" event
419394 register_webhook_event ("push" , should_fail = True )
420395 view = SyncWebhookView ()
421396
422- # Create event directly, bypassing webhook validation
423397 data = {"action" : "opened" }
424398 event = sansio .Event (data , event = "issues" , delivery_id = "12345" )
425399
426- # Mock the get_event method to return our event
427400 monkeypatch .setattr (view , "get_event" , lambda request : event )
428401
429- # Get count before
430402 count_before = EventLog .objects .count ()
431403
432- # Process request (with a dummy request)
433404 view .post (None )
434405
435- # Verify event log is not created when LOG_ALL_EVENTS=False
436406 count_after = EventLog .objects .count ()
437407 assert count_after - count_before == 0
0 commit comments