-
-
Notifications
You must be signed in to change notification settings - Fork 3
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Since gidgethub is async-first, this library has started out with only the ability to use in an async context. However, I would wager the vast, vast majority of Django projects out there are not async. django-github-app should support both sync and async contexts for this reason.
There are already some stubbed out classes that I created to make a note of where the sync code will need to go:
django_github_app.github.SyncGithubAPIdjango_github_app.views.SyncWebhookView
As well, the built-in events contained in django_github_app.events will need to be adjusted to provide sync handlers as well. I'm a little unsure about the best way to handle that..
All of the models already have sync and async methods, so there should need to be anything adjusted there to support sync.
TODO
-
django_github_app.github.SyncGithubAPI(implementSyncGitHubAPIclient #23) -
django_github_app.views.SyncWebhookView(implementSyncWebhookViewand refactorGitHubRouterfor sync support #31) - Create sync versions of internal events in
django_github_app.events(add sync handlers for internal webhook events #34)
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request
Projects
Status
Done