Skip to content

Add ability to use in sync Django applications #14

@joshuadavidthomas

Description

@joshuadavidthomas

Since gidgethub is async-first, this library has started out with only the ability to use in an async context. However, I would wager the vast, vast majority of Django projects out there are not async. django-github-app should support both sync and async contexts for this reason.

There are already some stubbed out classes that I created to make a note of where the sync code will need to go:

  • django_github_app.github.SyncGithubAPI
  • django_github_app.views.SyncWebhookView

As well, the built-in events contained in django_github_app.events will need to be adjusted to provide sync handlers as well. I'm a little unsure about the best way to handle that..

All of the models already have sync and async methods, so there should need to be anything adjusted there to support sync.

TODO

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions