Skip to content

Limit events saved to EventLog to events actually listened forΒ #70

@joshuadavidthomas

Description

@joshuadavidthomas

πŸ‘€ This would actually be a good improvement to bring to django-github-app, I think.

The project originally spun out of an internal service I wrote get around the limitation of the audit logs in GitHub only going back a few weeks. We had an API key leak by a contractor and my boss wanted audit logs around when the change was pushed, but it was outside the window of those few weeks. So really, initially it was written to store all events as an audit log.

On top of that, I think my thought process was it was just simpler to store all events sent to the webhook -- the rationale also being if you subscribe to the event in the GitHub admin, we should store it. But my internal GitHub apps using django-github-app aren't quite on the scale of python/cpython πŸ˜„.

Anyway, sorry for the random thought dump on your PR -- it came up on my main GitHub explore feed and got me thinking.

Originally posted by @joshuadavidthomas in psf/clabot#8 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions