simplify Span struct and remove salsa tracking (#205)

joshuadavidthomas · web-flow · commit 03f18d22117a · 2025-09-08T21:56:40.000-05:00
diff --git a/crates/djls-templates/src/ast.rs b/crates/djls-templates/src/ast.rs
@@ -57,16 +57,16 @@ impl Default for LineOffsets {
 #[derive(Clone, Debug, PartialEq, Eq, salsa::Update)]
 pub enum Node<'db> {
     Tag(TagNode<'db>),
-    Comment(CommentNode<'db>),
-    Text(TextNode<'db>),
+    Comment(CommentNode),
+    Text(TextNode),
     Variable(VariableNode<'db>),
 }
 
 #[derive(Debug, Clone, PartialEq, Eq, salsa::Update)]
 pub struct TagNode<'db> {
     pub name: TagName<'db>,
     pub bits: Vec<String>,
-    pub span: Span<'db>,
+    pub span: Span,
 }
 
 #[salsa::interned(debug)]
@@ -75,22 +75,22 @@ pub struct TagName<'db> {
 }
 
 #[derive(Debug, Clone, PartialEq, Eq, salsa::Update)]
-pub struct CommentNode<'db> {
+pub struct CommentNode {
     pub content: String,
-    pub span: Span<'db>,
+    pub span: Span,
 }
 
 #[derive(Debug, Clone, PartialEq, Eq, salsa::Update)]
-pub struct TextNode<'db> {
+pub struct TextNode {
     pub content: String,
-    pub span: Span<'db>,
+    pub span: Span,
 }
 
 #[derive(Debug, Clone, PartialEq, Eq, salsa::Update)]
 pub struct VariableNode<'db> {
     pub var: VariableName<'db>,
     pub filters: Vec<FilterName<'db>>,
-    pub span: Span<'db>,
+    pub span: Span,
 }
 
 #[salsa::interned(debug)]
@@ -103,29 +103,29 @@ pub struct FilterName<'db> {
     pub text: String,
 }
 
-#[salsa::tracked(debug)]
-pub struct Span<'db> {
-    #[tracked]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize)]
+pub struct Span {
     pub start: u32,
-    #[tracked]
     pub length: u32,
 }
 
-impl<'db> Span<'db> {
-    pub fn from_token(db: &'db dyn crate::db::Db, token: &Token) -> Self {
+impl Span {
+    #[must_use]
+    pub fn new(start: u32, length: u32) -> Self {
+        Self { start, length }
+    }
+
+    #[must_use]
+    pub fn from_token(token: &Token) -> Self {
         let start = token.start().unwrap_or(0);
         let length = u32::try_from(token.lexeme().len()).unwrap_or(0);
-        Span::new(db, start, length)
+        Self { start, length }
     }
 
     #[must_use]
-    pub fn to_lsp_range(
-        &self,
-        db: &'db dyn crate::db::Db,
-        line_offsets: &LineOffsets,
-    ) -> tower_lsp_server::lsp_types::Range {
-        let start_pos = self.start(db) as usize;
-        let end_pos = (self.start(db) + self.length(db)) as usize;
+    pub fn to_lsp_range(&self, line_offsets: &LineOffsets) -> tower_lsp_server::lsp_types::Range {
+        let start_pos = self.start as usize;
+        let end_pos = (self.start + self.length) as usize;
 
         let (start_line, start_char) = line_offsets.position_to_line_col(start_pos);
         let (end_line, end_char) = line_offsets.position_to_line_col(end_pos);
@@ -151,105 +151,52 @@ pub enum AstError {
     InvalidTagStructure {
         tag: String,
         reason: String,
-        span_start: u32,
-        span_length: u32,
+        span: Span,
     },
     #[error("Unbalanced structure: '{opening_tag}' missing closing '{expected_closing}'")]
     UnbalancedStructure {
         opening_tag: String,
         expected_closing: String,
-        opening_span_start: u32,
-        opening_span_length: u32,
-        closing_span_start: Option<u32>,
-        closing_span_length: Option<u32>,
+        opening_span: Span,
+        closing_span: Option<Span>,
     },
     #[error("Invalid {node_type} node: {reason}")]
     InvalidNode {
         node_type: String,
         reason: String,
-        span_start: u32,
-        span_length: u32,
+        span: Span,
     },
     #[error("Unclosed tag: {tag}")]
-    UnclosedTag {
-        tag: String,
-        span_start: u32,
-        span_length: u32,
-    },
+    UnclosedTag { tag: String, span: Span },
     #[error("Orphaned tag '{tag}' - {context}")]
     OrphanedTag {
         tag: String,
         context: String,
-        span_start: u32,
-        span_length: u32,
+        span: Span,
     },
     #[error("endblock '{name}' does not match any open block")]
-    UnmatchedBlockName {
-        name: String,
-        span_start: u32,
-        span_length: u32,
-    },
+    UnmatchedBlockName { name: String, span: Span },
     #[error("Tag '{tag}' requires at least {min} argument{}", if *.min == 1 { "" } else { "s" })]
-    MissingRequiredArguments {
-        tag: String,
-        min: usize,
-        span_start: u32,
-        span_length: u32,
-    },
+    MissingRequiredArguments { tag: String, min: usize, span: Span },
     #[error("Tag '{tag}' accepts at most {max} argument{}", if *.max == 1 { "" } else { "s" })]
-    TooManyArguments {
-        tag: String,
-        max: usize,
-        span_start: u32,
-        span_length: u32,
-    },
+    TooManyArguments { tag: String, max: usize, span: Span },
 }
 
 impl AstError {
     /// Get the span start and length of this error, if available
     #[must_use]
     pub fn span(&self) -> Option<(u32, u32)> {
         match self {
-            AstError::UnbalancedStructure {
-                opening_span_start,
-                opening_span_length,
-                ..
-            } => Some((*opening_span_start, *opening_span_length)),
-            AstError::InvalidTagStructure {
-                span_start,
-                span_length,
-                ..
-            }
-            | AstError::InvalidNode {
-                span_start,
-                span_length,
-                ..
-            }
-            | AstError::UnclosedTag {
-                span_start,
-                span_length,
-                ..
-            }
-            | AstError::OrphanedTag {
-                span_start,
-                span_length,
-                ..
-            }
-            | AstError::UnmatchedBlockName {
-                span_start,
-                span_length,
-                ..
-            }
-            | AstError::MissingRequiredArguments {
-                span_start,
-                span_length,
-                ..
+            AstError::UnbalancedStructure { opening_span, .. } => {
+                Some((opening_span.start, opening_span.length))
             }
-            | AstError::TooManyArguments {
-                span_start,
-                span_length,
-                ..
-            } => Some((*span_start, *span_length)),
+            AstError::InvalidTagStructure { span, .. }
+            | AstError::InvalidNode { span, .. }
+            | AstError::UnclosedTag { span, .. }
+            | AstError::OrphanedTag { span, .. }
+            | AstError::UnmatchedBlockName { span, .. }
+            | AstError::MissingRequiredArguments { span, .. }
+            | AstError::TooManyArguments { span, .. } => Some((span.start, span.length)),
             AstError::EmptyAst => None,
         }
     }
diff --git a/crates/djls-templates/src/lib.rs b/crates/djls-templates/src/lib.rs
@@ -163,8 +163,8 @@ fn accumulate_error(db: &dyn Db, error: &TemplateError, line_offsets: &LineOffse
     let range = error
         .span()
         .map(|(start, length)| {
-            let span = crate::ast::Span::new(db, start, length);
-            span.to_lsp_range(db, line_offsets)
+            let span = crate::ast::Span::new(start, length);
+            span.to_lsp_range(line_offsets)
         })
         .unwrap_or_default();
 
diff --git a/crates/djls-templates/src/parser.rs b/crates/djls-templates/src/parser.rs
@@ -101,7 +101,7 @@ impl<'db> Parser<'db> {
 
         Ok(Node::Comment(CommentNode {
             content: token.content(),
-            span: Span::from_token(self.db, &token),
+            span: Span::from_token(&token),
         }))
     }
 
@@ -116,7 +116,7 @@ impl<'db> Parser<'db> {
         let name_str = args.first().ok_or(ParserError::EmptyTag)?.clone();
         let name = TagName::new(self.db, name_str); // Intern the tag name
         let bits = args.into_iter().skip(1).collect();
-        let span = Span::from_token(self.db, &token);
+        let span = Span::from_token(&token);
 
         Ok(Node::Tag(TagNode { name, bits, span }))
     }
@@ -137,7 +137,7 @@ impl<'db> Parser<'db> {
             .skip(1)
             .map(|s| FilterName::new(self.db, s.trim().to_string())) // Intern filter names
             .collect();
-        let span = Span::from_token(self.db, &token);
+        let span = Span::from_token(&token);
 
         Ok(Node::Variable(VariableNode { var, filters, span }))
     }
@@ -175,7 +175,7 @@ impl<'db> Parser<'db> {
         let offset = u32::try_from(text.find(content.as_str()).unwrap_or(0))
             .expect("Offset should fit in u32");
         let length = u32::try_from(content.len()).expect("Content length should fit in u32");
-        let span = Span::new(self.db, start + offset, length);
+        let span = Span::new(start + offset, length);
 
         Ok(Node::Text(TextNode { content, span }))
     }
@@ -404,20 +404,20 @@ mod tests {
                 Node::Tag(TagNode { name, bits, span }) => TestNode::Tag {
                     name: name.text(db).to_string(),
                     bits: bits.clone(),
-                    span: (span.start(db), span.length(db)),
+                    span: (span.start, span.length),
                 },
                 Node::Comment(CommentNode { content, span }) => TestNode::Comment {
                     content: content.clone(),
-                    span: (span.start(db), span.length(db)),
+                    span: (span.start, span.length),
                 },
                 Node::Text(TextNode { content, span }) => TestNode::Text {
                     content: content.clone(),
-                    span: (span.start(db), span.length(db)),
+                    span: (span.start, span.length),
                 },
                 Node::Variable(VariableNode { var, filters, span }) => TestNode::Variable {
                     var: var.text(db).to_string(),
                     filters: filters.iter().map(|f| f.text(db).to_string()).collect(),
-                    span: (span.start(db), span.length(db)),
+                    span: (span.start, span.length),
                 },
             }
         }
diff --git a/crates/djls-templates/src/validation.rs b/crates/djls-templates/src/validation.rs
