use nightly rustfmt and sort imports (#145)

Author: joshuadavidthomas

.github/workflows/lint.yml

@@ -26,6 +26,12 @@ jobs:
         with:
           persist-credentials: false
 
+      - name: Install nightly toolchain for rustfmt
+        uses: dtolnay/rust-toolchain@b3b07ba8b418998c39fb20f53e8b695cdcc8de1b
+        with:
+          toolchain: nightly
+          components: rustfmt
+
       - name: Install uv
         uses: astral-sh/setup-uv@6b9c6063abd6010835644d4c2e1bef4cf5cd0fca  # v6.0.1
         with:

.pre-commit-config.yaml

@@ -29,7 +29,7 @@ repos:
         types:
           - rust
         language: rust
-        entry: cargo fmt
+        entry: cargo +nightly fmt
         args:
           - --
       - id: check

.rustfmt.toml

@@ -0,0 +1,5 @@
+group_imports = "StdExternalCrate"
+imports_granularity = "Item"
+imports_layout = "Vertical"
+reorder_imports = true
+unstable_features = true

crates/djls-conf/src/lib.rs

@@ -1,7 +1,12 @@
-use config::{Config, ConfigError as ExternalConfigError, File, FileFormat};
+use std::fs;
+use std::path::Path;
+
+use config::Config;
+use config::ConfigError as ExternalConfigError;
+use config::File;
+use config::FileFormat;
 use directories::ProjectDirs;
 use serde::Deserialize;
-use std::{fs, path::Path};
 use thiserror::Error;
 
 #[derive(Error, Debug)]
@@ -85,10 +90,12 @@ impl Settings {
 
 #[cfg(test)]
 mod tests {
-    use super::*;
     use std::fs;
+
     use tempfile::tempdir;
 
+    use super::*;
+
     mod defaults {
         use super::*;
 

crates/djls-project/src/lib.rs

@@ -4,14 +4,16 @@ mod python;
 mod system;
 mod templatetags;
 
+use std::fmt;
+use std::path::Path;
+use std::path::PathBuf;
+
 use db::ProjectDatabase;
 use meta::ProjectMetadata;
-use python::{find_python_environment, PythonEnvironment};
-pub use templatetags::TemplateTags;
-
 use pyo3::prelude::*;
-use std::fmt;
-use std::path::{Path, PathBuf};
+use python::find_python_environment;
+use python::PythonEnvironment;
+pub use templatetags::TemplateTags;
 
 #[derive(Debug)]
 pub struct DjangoProject {
@@ -90,10 +92,12 @@ impl fmt::Display for DjangoProject {
 
 #[cfg(test)]
 mod tests {
-    use super::*;
     use std::fs;
+
     use tempfile::tempdir;
 
+    use super::*;
+
     fn create_mock_django_project(dir: &Path) -> PathBuf {
         let project_path = dir.to_path_buf();
         fs::create_dir_all(&project_path).unwrap();

crates/djls-project/src/python.rs

@@ -1,8 +1,11 @@
+use std::fmt;
+use std::path::Path;
+use std::path::PathBuf;
+
+use pyo3::prelude::*;
+
 use crate::db::Db;
 use crate::system;
-use pyo3::prelude::*;
-use std::fmt;
-use std::path::{Path, PathBuf};
 
 #[salsa::tracked]
 pub fn find_python_environment(db: &dyn Db) -> Option<PythonEnvironment> {
@@ -152,12 +155,14 @@ impl fmt::Display for PythonEnvironment {
 
 #[cfg(test)]
 mod tests {
-    use super::*;
     use std::fs;
     #[cfg(unix)]
     use std::os::unix::fs::PermissionsExt;
+
     use tempfile::tempdir;
 
+    use super::*;
+
     fn create_mock_venv(dir: &Path, version: Option<&str>) -> PathBuf {
         let prefix = dir.to_path_buf();
 
@@ -200,10 +205,14 @@ mod tests {
     }
 
     mod env_discovery {
-        use super::*;
-        use crate::system::mock::{self as sys_mock, MockGuard};
         use which::Error as WhichError;
 
+        use super::*;
+        use crate::system::mock::MockGuard;
+        use crate::system::mock::{
+            self as sys_mock,
+        };
+
         #[test]
         fn test_explicit_venv_path_found() {
             let project_dir = tempdir().unwrap();

crates/djls-project/src/system.rs

@@ -1,5 +1,6 @@
 use std::env::VarError;
 use std::path::PathBuf;
+
 use which::Error as WhichError;
 
 pub fn find_executable(name: &str) -> Result<PathBuf, WhichError> {
@@ -26,11 +27,12 @@ pub fn env_var(key: &str) -> Result<String, VarError> {
 
 #[cfg(test)]
 pub mod mock {
-    use super::*;
     use std::cell::RefCell;
     use std::collections::HashMap;
     use std::thread_local;
 
+    use super::*;
+
     thread_local! {
         static MOCK_EXEC_RESULTS: RefCell<HashMap<String, Result<PathBuf, WhichError>>> = RefCell::new(HashMap::new());
         static MOCK_ENV_RESULTS: RefCell<HashMap<String, Result<String, VarError>>> = RefCell::new(HashMap::new());
@@ -95,12 +97,17 @@ pub mod mock {
 
 #[cfg(test)]
 mod tests {
-    use super::mock::{self as sys_mock, MockGuard};
-    use super::*;
     use std::env::VarError;
     use std::path::PathBuf;
+
     use which::Error as WhichError;
 
+    use super::mock::MockGuard;
+    use super::mock::{
+        self as sys_mock,
+    };
+    use super::*;
+
     #[test]
     fn test_exec_mock_path_retrieval() {
         let _guard = MockGuard;

crates/djls-project/src/templatetags.rs

@@ -1,7 +1,9 @@
-use pyo3::prelude::*;
-use pyo3::types::{PyDict, PyList};
 use std::ops::Deref;
 
+use pyo3::prelude::*;
+use pyo3::types::PyDict;
+use pyo3::types::PyList;
+
 #[derive(Debug, Default, Clone)]
 pub struct TemplateTags(Vec<TemplateTag>);
 

crates/djls-server/src/documents.rs

@@ -1,6 +1,8 @@
-use anyhow::{anyhow, Result};
-use djls_project::TemplateTags;
 use std::collections::HashMap;
+
+use anyhow::anyhow;
+use anyhow::Result;
+use djls_project::TemplateTags;
 use tower_lsp_server::lsp_types::*;
 
 #[derive(Debug, Default)]

crates/djls-server/src/queue.rs

@@ -1,8 +1,11 @@
-use anyhow::{anyhow, Result};
 use std::future::Future;
 use std::pin::Pin;
 use std::sync::Arc;
-use tokio::sync::{mpsc, oneshot};
+
+use anyhow::anyhow;
+use anyhow::Result;
+use tokio::sync::mpsc;
+use tokio::sync::oneshot;
 
 /// Type alias for a type-erased, pinned, heap-allocated, Send-able future
 /// that resolves to `Result<()>`.
@@ -186,12 +189,15 @@ impl Drop for QueueInner {
 
 #[cfg(test)]
 mod tests {
-    use super::*;
-    use anyhow::anyhow;
-    use std::sync::atomic::{AtomicUsize, Ordering};
+    use std::sync::atomic::AtomicUsize;
+    use std::sync::atomic::Ordering;
     use std::time::Duration;
+
+    use anyhow::anyhow;
     use tokio::time::sleep;
 
+    use super::*;
+
     #[tokio::test]
     async fn test_submit_and_process() {
         let queue = Queue::new();