Add 'require-dependency' rule

Author: jj-ivx

lib/rules/require-dependency.js

@@ -0,0 +1,32 @@
+'use strict';
+
+const { isSubPath, packages, getImport } = require('../utils');
+
+module.exports.meta = {
+  type: 'problem',
+  docs: {
+    url:
+      'https://github.com/joshuajaco/eslint-plugin-workspaces/docs/rules/require-dependency.md',
+  },
+};
+
+module.exports.create = context =>
+  getImport(context, ({ node, value, path }) => {
+    const { dependencies, name: currentPackage } = packages.find(
+      ({ location }) => isSubPath(location, context.getFilename()),
+    );
+
+    packages.forEach(({ name, location }) => {
+      if (
+        name !== currentPackage &&
+        (isSubPath(name, value) || isSubPath(location, path)) &&
+        !Object.keys(dependencies).includes(name)
+      ) {
+        context.report({
+          node,
+          message:
+            'Importing packages without listing them as dependency is not allowed',
+        });
+      }
+    });
+  });

lib/utils.js

@@ -9,7 +9,11 @@ const isSubPath = (parent, path) => {
 };
 
 const packages = getPackages(process.cwd()).map(
-  ({ package: { name }, location }) => ({ name, location }),
+  ({ package: { name, dependencies = {} }, location }) => ({
+    name,
+    location,
+    dependencies,
+  }),
 );
 
 const getImport = (context, callback) => ({

tests/rules/require-dependency.js

@@ -0,0 +1,25 @@
+'use strict';
+
+const ruleTester = require('../ruleTester');
+const rule = require('../../lib/rules/require-dependency');
+
+ruleTester.run('require-dependency', rule, {
+  valid: [
+    {
+      filename: '/test/another-workspace/index.js',
+      code: "import '../workspace';",
+    },
+  ],
+  invalid: [
+    {
+      filename: '/test/workspace/index.js',
+      code: "import '../another-workspace';",
+      errors: [
+        {
+          message:
+            'Importing packages without listing them as dependency is not allowed',
+        },
+      ],
+    },
+  ],
+});

tests/setup.js

@@ -3,9 +3,17 @@
 const mock = require('mock-require');
 
 mock('get-monorepo-packages', () => [
-  { location: '/test/workspace', package: { name: '@test/workspace' } },
+  {
+    location: '/test/workspace',
+    package: {
+      name: '@test/workspace',
+    },
+  },
   {
     location: '/test/another-workspace',
-    package: { name: '@test/another-workspace' },
+    package: {
+      name: '@test/another-workspace',
+      dependencies: { '@test/workspace': '^1.0.0' },
+    },
   },
 ]);