Skip to content

Commit 9ff6b6d

Browse files
committed
Clean up unnecessary args
1 parent ef52503 commit 9ff6b6d

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

base-sha.Dockerfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ RUN apt-get update && \
2828
apt-get install -y git make gcc libgmp-dev curl
2929

3030
ENV DEBIAN_FRONTEND noninteractive
31-
ARG IDRIS_VERSION
3231
# SHA of the latest commit on the idris-lang/idris2 repo
3332
ARG IDRIS_SHA
3433

@@ -38,8 +37,6 @@ COPY --from=scheme-builder /root/scheme-lib/ /usr/lib/
3837
COPY --from=scheme-builder /root/scheme-lib/ /root/scheme-lib
3938

4039
WORKDIR /root
41-
# if IDRIS_VERSION is 'latest', do not switch to a branch. Checkout the latest commit - ensures docker cache won't use stale versions
42-
# https://stackoverflow.com/a/41361804
4340
RUN git clone https://github.com/idris-lang/Idris2.git && cd Idris2 && git checkout $IDRIS_SHA
4441
WORKDIR /root/Idris2
4542
RUN make bootstrap SCHEME=scheme && make install
@@ -58,5 +55,4 @@ RUN make clean && make all && make install
5855
RUN make install-api
5956

6057
# re-expose version information
61-
ENV IDRIS_VERSION=$IDRIS_VERSION
6258
ENV IDRIS_SHA=$IDRIS_SHA

devcontainer-sha.Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ FROM mcr.microsoft.com/vscode/devcontainers/base:bullseye
5454

5555
ARG IDRIS_LSP_VERSION=latest
5656
ARG IDRIS_LSP_SHA
57-
ARG IDRIS_VERSION
5857
ARG IDRIS_SHA
5958

6059
# idris2 + idris2-lsp compiled from source
@@ -72,6 +71,5 @@ ENV SCHEME=scheme
7271
# re-expose version information
7372
ENV IDRIS_LSP_VERSION=$IDRIS_LSP_VERSION
7473
ENV IDRIS_LSP_SHA=$IDRIS_LSP_SHA
75-
ENV IDRIS_VERSION=$IDRIS_VERSION
7674
ENV IDRIS_SHA=$IDRIS_SHA
7775

0 commit comments

Comments
 (0)