Skip to content

Commit cd76f2f

Browse files
committed
Type cast verified attribute
1 parent 2845eb8 commit cd76f2f

File tree

4 files changed

+17
-7
lines changed

4 files changed

+17
-7
lines changed

src/Traits/CanVerifyEmail.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,14 @@ public function sendEmailVerificationNotification($token, $expiration)
3434
$this->notify(new EmailVerificationNotification($token, $expiration));
3535
}
3636

37+
/**
38+
* Get the verified attribute
39+
*
40+
* @return bool
41+
*/
42+
public function getVerifiedAttribute($verified)
43+
{
44+
return (bool) $verified;
45+
}
46+
3747
}

src/Traits/VerifiesEmail.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ protected function verifiedEmail($user)
9696
{
9797
$this->guard()->login($user);
9898

99-
if(!(boolean)$user->verified) {
99+
if(!$user->verified) {
100100
$user->forceFill([
101101
'verified' => true
102102
])->save();

tests/Feature/RegistrationTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function testRegistration()
4545
[$user], EmailVerification::class
4646
);
4747

48-
$this->assertFalse((boolean)$user->verified);
48+
$this->assertFalse($user->verified);
4949

5050
$notification = Notification::sent($user, EmailVerification::class)->first();
5151

@@ -59,7 +59,7 @@ public function testRegistration()
5959
$response->assertSessionHas('success');
6060

6161
$user->refresh();
62-
$this->assertTrue((boolean)$user->verified);
62+
$this->assertTrue($user->verified);
6363

6464

6565
}
@@ -86,7 +86,7 @@ public function testEmitsUserVerifedEventOnce()
8686
return $e->user->is($user);
8787
});
8888

89-
$this->assertTrue((boolean)$user->fresh()->verified);
89+
$this->assertTrue($user->fresh()->verified);
9090

9191

9292
// Open activation URL second time
@@ -95,7 +95,7 @@ public function testEmitsUserVerifedEventOnce()
9595

9696
$this->assertCount(1, Event::dispatched(UserVerified::class));
9797

98-
$this->assertTrue((boolean)$user->fresh()->verified);
98+
$this->assertTrue($user->fresh()->verified);
9999

100100

101101
}

tests/Feature/ResendVerificationMailTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function testResend() {
4444
[$user], EmailVerification::class
4545
);
4646

47-
$this->assertFalse((boolean)$user->verified);
47+
$this->assertFalse($user->verified);
4848

4949
$notification = Notification::sent($user, EmailVerification::class)->first();
5050

@@ -56,7 +56,7 @@ public function testResend() {
5656
$response->assertSessionHas('success');
5757

5858
$user->refresh();
59-
$this->assertTrue((boolean)$user->verified);
59+
$this->assertTrue($user->verified);
6060
$this->assertEquals('[email protected]', $user->email);
6161

6262

0 commit comments

Comments
 (0)