Skip to content

Commit 0c7ceb7

Browse files
authored
fix pub.dev score, update readme, update publish CD (#373)
tackle some tasks from #368
1 parent b6324e8 commit 0c7ceb7

File tree

5 files changed

+35
-23
lines changed

5 files changed

+35
-23
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ jobs:
177177
sudo apt-get install webp && \
178178
dart pub global activate pana
179179
- name: Check package score
180-
run: pana --exit-code-threshold 150 --no-dartdoc .
180+
run: pana --exit-code-threshold 10 --no-dartdoc .
181181
build-android:
182182
name: "[Android] Build APK"
183183
runs-on: ubuntu-latest
@@ -236,7 +236,7 @@ jobs:
236236
uses: actions/upload-artifact@v4
237237
with:
238238
name: maplibre-flutter-demo.app
239-
path: maplibre_ios/example/build/ios/iphonesimulator
239+
path: build/ios/iphonesimulator
240240
build-web:
241241
name: "[Web] Build"
242242
runs-on: ubuntu-latest

.github/workflows/publish.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ jobs:
1515
working-directory: maplibre_ios
1616
publish-maplibre:
1717
name: "Publish `maplibre`"
18+
needs: publish-maplibre-ios
1819
permissions:
1920
id-token: write
2021
uses: dart-lang/setup-dart/.github/workflows/publish.yml@v1

README.md

Lines changed: 27 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -28,53 +28,53 @@ rendering while supporting advanced mapping features.
2828
<tbody>
2929
<tr>
3030
<td style="text-align: center;">
31-
<strong>View the planet as a globe</strong>
31+
<strong>Globe View</strong>
3232
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/2244278ecb87117286a8c3fbad89717bc1231a1d/globe%20view.jpg" alt="Tilted and rotated map" />
3333
</td>
3434
<td style="text-align: center;">
35-
<strong>Use custom vector styles</strong>
35+
<strong>Custom Styling</strong>
3636
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/d8e2c7daf15221f716a2ebbd63e57a317cb089ab/docs/static/img/showcase-map.jpg" alt="Custom styled map" />
3737
</td>
3838
<td style="text-align: center;">
39-
<strong>Pitch or rotate the map</strong>
39+
<strong>Pitch and Rotate</strong>
4040
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/2244278ecb87117286a8c3fbad89717bc1231a1d/tilt%20map.jpg" alt="Tilted and rotated map" />
4141
</td>
4242
</tr>
4343
<tr>
4444
<td style="text-align: center;">
45-
<strong>Use raster tiles</strong>
45+
<strong>Raster Tiles</strong>
4646
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/427311f8f4577c215bf73caf46e3769629e74e3b/docs/static/img/layers/raster_layer.jpg" alt="Fill Layer" />
4747
</td>
4848
<td style="text-align: center;">
49-
<strong>Add 3D building outlines</strong>
49+
<strong>3D Building Outlines</strong>
5050
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/427311f8f4577c215bf73caf46e3769629e74e3b/docs/static/img/layers/fill_extrusion_layer.jpg" alt="Fill Extrusion Layer" />
5151
</td>
5252
<td style="text-align: center;">
53-
<strong>Add heatmaps</strong>
53+
<strong>Heatmaps</strong>
5454
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/427311f8f4577c215bf73caf46e3769629e74e3b/docs/static/img/layers/heatmap_layer.jpg" alt="Fill Layer" />
5555
</td>
5656
</tr>
5757
<tr>
5858
<td style="text-align: center;">
59-
<strong>Add polygons</strong>
59+
<strong>Polygons</strong>
6060
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/427311f8f4577c215bf73caf46e3769629e74e3b/docs/static/img/layers/fill_layer.jpg" alt="Fill Layer" />
6161
</td>
6262
<td style="text-align: center;">
63-
<strong>Render elevation</strong>
63+
<strong>Elevation</strong>
6464
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/427311f8f4577c215bf73caf46e3769629e74e3b/docs/static/img/layers/hillshade_layer.jpg" alt="Fill Extrusion Layer" />
6565
</td>
6666
<td style="text-align: center;">
67-
<strong>Add lines</strong>
67+
<strong>Lines</strong>
6868
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/427311f8f4577c215bf73caf46e3769629e74e3b/docs/static/img/layers/line_layer.jpg" alt="Fill Layer" />
6969
</td>
7070
</tr>
7171
<tr>
7272
<td style="text-align: center;">
73-
<strong>Add circles</strong>
73+
<strong>Circles</strong>
7474
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/fe660b8d1c055d32e74cbc2ee0809281331a130b/docs/static/img/layers/circle_layer.jpg" alt="Circle Layer" />
7575
</td>
7676
<td style="text-align: center;">
77-
<strong>Add markers</strong>
77+
<strong>Markers</strong>
7878
<img src="https://raw.githubusercontent.com/josxha/flutter-maplibre/427311f8f4577c215bf73caf46e3769629e74e3b/docs/static/img/layers/symbol_layer.jpg" alt="Symbol Layer" />
7979
</td>
8080
<td style="text-align: center;">
@@ -85,12 +85,14 @@ rendering while supporting advanced mapping features.
8585

8686
## Resources
8787

88-
### Demo Application
88+
### 📱Demo Application
89+
90+
Many features of the package are showcased in the example app.
8991

9092
- [Hosted Demo App](https://flutter-maplibre.pages.dev/demo)
9193
- [Code of the Example App](https://github.com/josxha/flutter-maplibre/tree/main/example/lib)
9294

93-
### Get Started & Documentation
95+
### 🤓Get Started & Documentation
9496

9597
Visit the docs to learn how to get started with maplibre in your
9698
project: [Get Started](https://flutter-maplibre.pages.dev/docs/category/getting-started)
@@ -99,19 +101,25 @@ If you want to know more about the classes and properties of the package, have
99101
a look at
100102
the [API docs](https://pub.dev/documentation/maplibre/latest/maplibre/maplibre-library.html).
101103

102-
## Development & Contributing
104+
## ❤️Development & Contributing
103105

104106
All kinds of contributions are welcome. Thanks a lot if you consider to
105107
contribute in any way! There are different ways how you can help the
106108
development:
107109

108-
- Use the package in your project
110+
- 🌟Give the project on [GitHub](https://github.com/josxha/flutter-maplibre)
111+
and [pub.dev](https://pub.dev/packages/maplibre).
112+
- 🪴Use the package in your project
109113
and [share feedback](https://github.com/josxha/flutter-maplibre/discussions/categories/show-and-tell).
110-
- [Open bug reports](https://github.com/josxha/flutter-maplibre/issues/new?assignees=&labels=bug&projects=&template=1-bug.yml&title=%5BBUG%5D+%3Ctitle%3E)
114+
- 🐛[Open bug reports](https://github.com/josxha/flutter-maplibre/issues/new?assignees=&labels=bug&projects=&template=1-bug.yml&title=%5BBUG%5D+%3Ctitle%3E)
111115
in case you find any.
112-
- If you need a specific
116+
- 💡If you need a specific
113117
feature, [open a feature request](https://github.com/josxha/flutter-maplibre/issues/new?assignees=&labels=feature&projects=&template=2-feature.yml&title=%5BFEATURE%5D+%3Ctitle%3E).
114118
or [post your idea as discussion](https://github.com/josxha/flutter-maplibre/discussions/categories/ideas).
115-
- Enhance the package documentation.
116-
- Sponsor this
119+
- 📖Enhance the package documentation.
120+
- 💝Sponsor this
117121
project: [GitHub-Sponsors](https://github.com/sponsors/josxha), [PayPal](https://www.paypal.com/paypalme/joschaeckert).
122+
123+
#### A huge thanks to all contributors! 😎
124+
125+
[![List of contributors](https://contrib.rocks/image?repo=josxha/flutter-maplibre)](https://github.com/josxha/flutter-maplibre/graphs/contributors)

lib/src/android_platform_view_mode.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Using an underscore to separate the different abbreviations.
12
// ignore_for_file: constant_identifier_names
23

34
/// The different ways a MapLibre map can be displayed on Android.

lib/src/layer/layer_manager.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import 'dart:async';
2+
13
import 'package:maplibre/maplibre.dart';
24

35
/// The layer manager handles the high-level layer API used in
@@ -15,8 +17,8 @@ class LayerManager {
1517
id: layer.getSourceId(index),
1618
data: FeatureCollection(layer.list).toText(),
1719
);
18-
style.addSource(source);
19-
style.addLayer(layer.createStyleLayer(index));
20+
unawaited(style.addSource(source));
21+
unawaited(style.addLayer(layer.createStyleLayer(index)));
2022
}
2123
_oldLayers = layers;
2224
}

0 commit comments

Comments
 (0)