feat: add geometry field to RenderedFeature#485
Draft
idompolo wants to merge 3 commits intojosxha:mainfrom
Draft
feat: add geometry field to RenderedFeature#485idompolo wants to merge 3 commits intojosxha:mainfrom
idompolo wants to merge 3 commits intojosxha:mainfrom
Conversation
Currently, `RenderedFeature` only exposes `id` and `properties`, discarding the geometry returned by the native `queryRenderedFeatures` API. This makes it impossible to get the geographic coordinates of queried features without workarounds like screen-to-geo coordinate conversion. This commit adds an optional `geometry` field to `RenderedFeature` and populates it on all platforms: - **Android**: Extract geometry via `Gson.toJson(feature.geometry())` - **iOS**: Use `MLNFeature.coordinate` to build a Point geometry - **Web**: Pass through the JS GeoJSON `geometry` object Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add StyleController.setFilter(layerId, filter) to dynamically update or clear filter expressions on existing style layers. - platform_interface: abstract setFilter method - Android: getLayer + setFilter via JNI Expression - iOS: layerWithIdentifier + MLNVectorStyleLayer.predicate Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Owner
|
@idompolo thanks for considering to contribute. I think that adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RenderedFeaturecurrently only exposesidandproperties, discarding the geometry from nativequeryRenderedFeaturesresultsgeometryfield (Map<String, Object?>?) toRenderedFeatureand populates it on all platformsChanges
queried_layer.dartgeometryfield toRenderedFeaturemap_state.dartGson.toJson(feature.geometry())→ JSON parseextensions.dartMLNFeature.coordinate→{type: Point, coordinates: [lon, lat]}map_geojson_feature.dart+map_state.dartgeometryobject viadartify()Use case
Test plan
featuresInRect+featuresAtPoint)geometryis optional, existing code unaffected