Merged
Conversation
Deploying flutter-maplibre with
|
| Latest commit: |
f6fd0c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://35a013b0.flutter-maplibre.pages.dev |
| Branch Preview URL: | https://fix-raster-and-raster-dem-so.flutter-maplibre.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where RasterSource and RasterDemSource were sending null values for tiles or url parameters to MapLibre GL JS, which was throwing errors. The solution splits each factory constructor into two separate private constructors - one for URL-based sources and one for tiles-based sources, conditionally selecting between them based on which parameter is non-null.
Changes:
- Refactored
SourceSpecification.rasterDemfrom an external factory to a regular factory that delegates to either_rasterDemUrlor_rasterDemTilesbased on whetherurlis non-null - Refactored
SourceSpecification.rasterfrom an external factory to a regular factory that delegates to either_rasterUrlor_rasterTilesbased on whetherurlis non-null
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RasterSource and RasterDemSource send
nullfortilesorurlif not set since recently. This throws an error in maplibre gl js. This pr only sets those parameters if not null.