Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: BrianUribe6

apps/front-end/src/app/DialogCollab.tsx

@@ -17,11 +17,7 @@ import { usePathname } from "next/navigation";
 import { useState } from "react";
 import { useIsCollaborationEnabled } from "@/lib/collaboration";
 
-type DialogCollabProps = {
-  notebookId: string;
-};
-
-export default function DialogCollab({ notebookId }: DialogCollabProps) {
+export default function DialogCollab() {
   const pathname = usePathname();
   const fullUrl = `${getOrigin()}${pathname}`;
   const [isCollaborationEnabled, setIsCollaborationEnabled] = useIsCollaborationEnabled();

apps/front-end/src/app/Header.tsx

@@ -1,16 +1,12 @@
 "use client";
 
-import { useParams } from "next/navigation";
 import ActiveUsers from "./ActiveUsers";
 import BreadcrumbsShell from "./BreadcrumbsShell";
 import DialogCollab from "./DialogCollab";
 import MobileNavigation from "./MobileNavigation";
 import UserProfileMenu from "./UserProfileMenu";
 
 function Header() {
-  const params = useParams();
-  const notebookId = params.notebookId as string;
-
   return (
     <header
       className="sticky top-0 z-10 flex items-center border-b border-gray-200 bg-white/90 p-4 
@@ -20,7 +16,7 @@ function Header() {
       <BreadcrumbsShell />
       <div className="ml-auto flex items-center space-x-4">
         <ActiveUsers />
-        <DialogCollab notebookId={notebookId} />
+        <DialogCollab />
         <UserProfileMenu />
       </div>
     </header>

apps/front-end/src/app/[notebookId]/[noteId]/page.tsx

@@ -3,7 +3,7 @@ import { Editor } from "@/components/Editor";
 export const dynamic = "force-dynamic";
 
 async function NotePage({ params }: { params: { noteId: string } }) {
-  return <Editor collaboration={{ documentId: params.noteId}} />;
+  return <Editor collaboration={{ documentId: params.noteId }} />;
 }
 
 export default NotePage;

apps/front-end/src/app/[notebookId]/layout.tsx

@@ -22,7 +22,7 @@ function Layout({ children, params }: LayoutProps) {
       // Enable collaboration by default when accessing a notebook that is not your own
       setIsCollaborationEnabled(true);
     }
-  }, []);
+  }, [identity.id, params.notebookId, setIsCollaborationEnabled]);
 
   return (
     <div className="grid lg:grid-cols-[20rem_auto]">

apps/front-end/src/lib/collaboration/StartCollaboration.tsx

@@ -38,9 +38,6 @@ export function StartCollaboration({ notebookId }: StartCollaborationProps) {
       id: identity.id,
       name: identity.name,
     });
-    return () => {
-      provider.setAwarenessField("user", null);
-    };
   }, [identity, provider]);
 
   return null;

apps/front-end/src/lib/identity-provider.tsx

@@ -4,5 +4,5 @@ import { useAtomValue } from "jotai";
 import { identityAtom, LocalIdentity } from "./local-identity";
 
 export function useLocalIdentity(): LocalIdentity {
-  return useAtomValue(identityAtom)
+  return useAtomValue(identityAtom);
 }