fix(useAtomDevtools): disconnect from redux devtools on unmount #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 07cd8bb:
|
arjunvegda
changed the title
dai-shi
approved these changes
Mar 8, 2023
Comment on lines
+110
to
+113
| return () => { | ||
| (extension as any).disconnect(); | ||
| unsubscribe?.(); | ||
| }; |
Member
There was a problem hiding this comment.
Yes, this looks like the correct fix. Thanks.
Member
There was a problem hiding this comment.
I misunderstood. Thought it's connection.disconnect().
dai-shi
requested changes
Mar 13, 2023
Member
dai-shi
left a comment
dai-shi
left a comment
There was a problem hiding this comment.
we need a feature from redux-devtools.
Comment on lines
+110
to
+113
| return () => { | ||
| (extension as any).disconnect(); | ||
| unsubscribe?.(); | ||
| }; |
Member
There was a problem hiding this comment.
I misunderstood. Thought it's connection.disconnect().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - pmndrs/jotai#1795 (reply in thread)
Edit: Blocked by reduxjs/redux-devtools#1370