Skip to content

Commit 669843f

Browse files
Merge pull request #65 from jotform/refactor/unnecessary-code-remove
refactor: unnecessary codes are removed
2 parents e827d4a + 3a00699 commit 669843f

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

src/components/Builder/Scene.js

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ const Scene = () => {
4545

4646
const [itemToPaste, setItemToPaste] = useState(null);
4747
const lastScrollPosition = useBuilderStore(state => state.lastScrollPosition);
48-
const isHeaderHidden = useRef(false);
4948

5049
const pageStyles = useRef({});
5150
const pageContainerStyles = useRef({});
@@ -104,12 +103,6 @@ const Scene = () => {
104103
}
105104
}, [lastScrollPosition]); // set last scroll position after changing mode
106105

107-
useEffect(() => {
108-
if (document.body.classList.contains('hideHeader') && isHeaderHidden) {
109-
document.body.classList.remove('hideHeader');
110-
}
111-
}, []); // reset hideHeader
112-
113106
const foundItem = findItemById(activeElement === null ? null : activeElement[0], pages);
114107

115108
const selectedItems = getSelectedItems(activeElement, pages);
@@ -261,19 +254,6 @@ const Scene = () => {
261254
}
262255
};
263256

264-
const onScroll = e => {
265-
const { scrollTop } = e.currentTarget;
266-
const hiddenHeaderHeight = 70;
267-
const headerHidingLimit = isHeaderHidden ? 230 : 300;
268-
if (scrollTop > headerHidingLimit + hiddenHeaderHeight && !isHeaderHidden.current) {
269-
isHeaderHidden.current = true;
270-
document.body.classList.add('hideHeader');
271-
} else if (scrollTop < headerHidingLimit && isHeaderHidden.current) {
272-
isHeaderHidden.current = false;
273-
document.body.classList.remove('hideHeader');
274-
}
275-
};
276-
277257
const shouldSuppressKeyboardEvent = e => (
278258
EVENT_IGNORED_ROLES.some(role => e.target.closest(`[role=${role}]`))
279259
);
@@ -330,7 +310,6 @@ const Scene = () => {
330310
ref={viewPortRef}
331311
className={classNames.viewport}
332312
data-zoom={zoom}
333-
onScroll={onScroll}
334313
>
335314
<div
336315
className={classNames.canvas}

0 commit comments

Comments
 (0)