Drop asset on emit event

Author: jouni-kantola

src/index.js

@@ -40,6 +40,14 @@ class InlineChunkManifestHtmlWebpackPlugin {
     const chunkManifestVariable = this.chunkManifestVariable;
     const dropAsset = this.dropAsset;
 
+    compiler.plugin("emit", (compilation, callback) => {
+      if (dropAsset) {
+        delete compilation.assets[manifestFilename];
+      }
+
+      callback();
+    });
+
     compiler.plugin("compilation", compilation => {
       compilation.plugin(
         "html-webpack-plugin-alter-asset-tags",
@@ -57,10 +65,6 @@ class InlineChunkManifestHtmlWebpackPlugin {
             };
 
             htmlPluginData.head.unshift(newTag);
-
-            if (dropAsset) {
-              delete compilation.assets[manifestFilename];
-            }
           }
 
           callback(null, htmlPluginData);

test/plugin-drop-asset-test.js

@@ -20,33 +20,22 @@ test.cb("keep asset", t => {
 });
 
 function isDropped(dropAsset, callback) {
-  const assets = {};
-  assets[manifestFilename] = {
+  const compilation = {
+    assets: {}
+  };
+  compilation.assets[manifestFilename] = {
     source: () => manifestFileContent
   };
 
-  const compilationPluginEvent = (compilationEvent, alterAssets) => {
-    if (compilationEvent === "html-webpack-plugin-alter-asset-tags") {
-      const htmlPluginData = {
-        head: []
-      };
-
-      alterAssets(htmlPluginData, (_, result) => {
-        const asset = assets[manifestFilename];
+  const pluginEvent = (event, emit) => {
+    if (event === "emit") {
+      emit(compilation, () => {
+        const asset = compilation.assets[manifestFilename];
         callback(asset);
       });
     }
   };
 
-  const pluginEvent = (compilerEvent, compile) => {
-    const compilation = {
-      plugin: compilationPluginEvent,
-      assets: assets
-    };
-
-    compile(compilation);
-  };
-
   const fakeCompiler = { plugin: pluginEvent };
 
   const plugin = new InlineChunkManifestHtmlWebpackPlugin({