Skip to content

Commit ebb698f

Browse files
committed
📝 Added descriptive variable names to function parameters
1 parent 4a3f2a4 commit ebb698f

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

digital_image_processing/morphological_operations/pruning_operation.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ def gray_to_binary(gray: np.ndarray) -> np.ndarray:
4343
return (gray > 127) & (gray <= 255)
4444

4545

46-
def neighbours(image: np.ndarray, x: int, y: int) -> list:
46+
def neighbours(image: np.ndarray, x_coord: int, y_coord: int) -> list:
4747
"""
48-
Return 8-neighbours of point (x, y), in clockwise order
48+
Return 8-neighbours of point (x_coord, y_coord), in clockwise order
4949
5050
>>> neighbours(
5151
... np.array(
@@ -84,15 +84,15 @@ def neighbours(image: np.ndarray, x: int, y: int) -> list:
8484
neighbour_points = []
8585

8686
for dx, dy in neighborhood:
87-
if 0 <= x + dx < img.shape[0] and 0 <= y + dy < img.shape[1]:
88-
neighbour_points.append(img[x + dx][y + dy])
87+
if 0 <= x_coord + dx < img.shape[0] and 0 <= y_coord + dy < img.shape[1]:
88+
neighbour_points.append(img[x_coord + dx][y_coord + dy])
8989
else:
9090
neighbour_points.append(False)
9191

9292
return neighbour_points
9393

9494

95-
def is_endpoint(image: np.ndarray, x: int, y: int) -> bool:
95+
def is_endpoint(image: np.ndarray, x_coord: int, y_coord: int) -> bool:
9696
"""
9797
Check if a pixel is an endpoint based on its 8-neighbors.
9898
@@ -121,7 +121,7 @@ def is_endpoint(image: np.ndarray, x: int, y: int) -> bool:
121121
True
122122
"""
123123
img = image
124-
return int(sum(neighbours(img, x, y))) == 1
124+
return int(sum(neighbours(img, x_coord, y_coord))) == 1
125125

126126

127127
def prune_skeletonized_image(

digital_image_processing/morphological_operations/skeletonization_operation.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ def gray_to_binary(gray: np.ndarray) -> np.ndarray:
4444
return (gray > 127) & (gray <= 255)
4545

4646

47-
def neighbours(image: np.ndarray, x: int, y: int) -> list:
47+
def neighbours(image: np.ndarray, x_coord: int, y_coord: int) -> list:
4848
"""
49-
Return 8-neighbours of point (x, y), in clockwise order
49+
Return 8-neighbours of point (x_coord, y_coord), in clockwise order
5050
5151
>>> neighbours(
5252
... np.array(
@@ -71,14 +71,14 @@ def neighbours(image: np.ndarray, x: int, y: int) -> list:
7171
"""
7272
img = image
7373
return [
74-
img[x - 1][y],
75-
img[x - 1][y + 1],
76-
img[x][y + 1],
77-
img[x + 1][y + 1],
78-
img[x + 1][y],
79-
img[x + 1][y - 1],
80-
img[x][y - 1],
81-
img[x - 1][y - 1],
74+
img[x_coord - 1][y_coord],
75+
img[x_coord - 1][y_coord + 1],
76+
img[x_coord][y_coord + 1],
77+
img[x_coord + 1][y_coord + 1],
78+
img[x_coord + 1][y_coord],
79+
img[x_coord + 1][y_coord - 1],
80+
img[x_coord][y_coord - 1],
81+
img[x_coord - 1][y_coord - 1],
8282
]
8383

8484

0 commit comments

Comments
 (0)