Add/update batch page tasks

Author: rossta

app/jobs/pages/batch_analyze_topics_job.rb

@@ -3,7 +3,10 @@ class BatchAnalyzeTopicsJob < ApplicationJob
     queue_as :default
 
     def perform
-      Page.where(request_path: SitepressArticle.published.map(&:request_path)).missing(:topics).find_each do |page|
+      scope = Page.where.missing(:topics)
+        .and(Page.where(request_path: SitepressArticle.published.map(&:request_path)))
+
+      scope.find_each do |page|
         Pages::AnalyzeTopicsJob.perform_later(page)
       end
     end

app/jobs/pages/batch_upsert_pages_job.rb

@@ -0,0 +1,16 @@
+module Pages
+  class BatchUpsertPagesJob < ApplicationJob
+    queue_as :default
+
+    def perform
+      [
+        SitepressArticle,
+        SitepressSlashPage
+      ].each do |sitepress_collection|
+        sitepress_collection.all.each do |sitepress_resource|
+          Page.find_or_create_by!(request_path: sitepress_resource.request_path)
+        end
+      end
+    end
+  end
+end

app/models/page.rb

@@ -17,10 +17,19 @@
 class Page < ApplicationRecord
   include Page::Searchable
 
+  NullResource = Data.define(:request_path) do
+    def data = NullData.new(title: nil, description: nil)
+  end
+
+  NullData = Data.define(:title, :description)
+
   has_many :page_topics, dependent: :destroy
   has_many :topics, through: :page_topics
   has_many :approved_topics, -> { approved }, through: :page_topics, source: :topic, inverse_of: :pages
 
+  # def resource_data
+  delegate :data, to: :resource, allow_nil: true, prefix: true
+
   def self.as_published_articles
     SitepressArticle.take_published(all.map { |page| SitepressArticle.new(page.resource) })
   end
@@ -29,7 +38,8 @@ def sitepress_article
     SitepressArticle.new(resource)
   end
 
-  def resource = Sitepress.site.get(request_path)
+  def resource = Sitepress.site.get(request_path) ||
+    NullResource.new(request_path: request_path)
 
   def body_text = Nokogiri::HTML(SitepressPage.render_html(resource)).text.squish
 

db/seeds/default/pages.rb

@@ -1,8 +1 @@
-[
-  SitepressArticle,
-  SitepressSlashPage
-].each do |sitepress_collection|
-  sitepress_collection.all.each do |sitepress_resource|
-    Page.find_or_create_by!(request_path: sitepress_resource.request_path)
-  end
-end
+Pages::BatchUpsertPagesJob.perform_now

spec/factories/pages.rb

@@ -13,6 +13,6 @@
 #
 FactoryBot.define do
   factory :page do
-    request_path { "/" }
+    request_path { "/" + Faker::Internet.slug }
   end
 end

spec/jobs/pages/batch_analyze_topics_job_spec.rb

@@ -0,0 +1,24 @@
+require "rails_helper"
+
+RSpec.describe Pages::BatchAnalyzeTopicsJob, type: :job do
+  it "doesn’t blow up" do
+    allow(SitepressPage).to receive(:render_html).and_return(Faker::HTML.random)
+
+    topics = FactoryBot.create_list(:topic, 2)
+
+    # articles without topics
+    Page.find_or_create_by!(request_path: "/articles/custom-color-schemes-with-ruby-on-rails")
+    Page.find_or_create_by!(request_path: "/articles/mastering-custom-configuration-in-rails")
+
+    # articles with topics
+    Page.find_or_create_by!(request_path: "/articles/web-push-notifications-from-rails")
+      .update!(topics: topics)
+
+    # not articles
+    FactoryBot.create_list(:page, 3)
+
+    expect(Pages::AnalyzeTopicsJob).to receive(:perform_later).exactly(2).times
+
+    described_class.perform_now
+  end
+end

spec/jobs/pages/batch_upsert_pages_job_spec.rb

@@ -0,0 +1,22 @@
+require "rails_helper"
+
+RSpec.describe Pages::BatchUpsertPagesJob, type: :job do
+  it "creates pages for sitepress resources" do
+    described_class.perform_now
+
+    expect(Page.count).to eq(
+      SitepressArticle.all.resources.size +
+      SitepressSlashPage.all.resources.size
+    )
+
+    expect(Page.pluck(:request_path)).to include("/articles/custom-color-schemes-with-ruby-on-rails")
+  end
+
+  it "is idempotent" do
+    described_class.perform_now
+
+    expect {
+      described_class.perform_now
+    }.not_to change(Page, :count)
+  end
+end