Remove flash message for newsletter create

Because redirect page already implements a success message

Author: rossta

app/controllers/users/newsletter_subscriptions_controller.rb

@@ -44,8 +44,7 @@ def create
       # TODO: Send already subscribed email
     end
 
-    redirect_to users_newsletter_subscription_path(@newsletter_subscription),
-      notice: "Welcome to Joy of Rails! Please check your email for confirmation instructions"
+    redirect_to users_newsletter_subscription_path(@newsletter_subscription)
   end
 
   def subscribe

spec/requests/users/newsletter_subscriptions_spec.rb

@@ -68,7 +68,6 @@
       }.to change(User, :count).by(1)
 
       expect(response).to redirect_to(users_newsletter_subscription_path(User.last.newsletter_subscription))
-      expect(flash[:notice]).to eq("Welcome to Joy of Rails! Please check your email for confirmation instructions")
 
       perform_enqueued_jobs_and_subsequently_enqueued_jobs
 
@@ -90,7 +89,6 @@
       }.not_to change(NewsletterSubscription, :count)
 
       expect(response).to redirect_to(users_newsletter_subscription_path(User.last.newsletter_subscription))
-      expect(flash[:notice]).to eq("Welcome to Joy of Rails! Please check your email for confirmation instructions")
 
       expect(user.reload.newsletter_subscription).to be_present
       # assert "already subscribed" email sent
@@ -105,7 +103,6 @@
       }.to change(NewsletterSubscription, :count).by(1)
 
       expect(response).to redirect_to(users_newsletter_subscription_path(User.last.newsletter_subscription))
-      expect(flash[:notice]).to eq("Welcome to Joy of Rails! Please check your email for confirmation instructions")
 
       expect(user.reload.newsletter_subscription).to be_present
     end