Add feature gate for example posts

System tests need additional css scoping due to ambiguous match of
"form" on posts page; when user is logged in, a sign out button is also
rendered within a form element.

Author: rossta

app/controllers/examples/posts_controller.rb

@@ -1,4 +1,6 @@
 class Examples::PostsController < ApplicationController
+  before_action :feature_enabled!
+
   def index
     render Examples::Posts::IndexView.new(posts: Examples::Post.limit(25).order(created_at: :desc))
   end
@@ -26,4 +28,11 @@ def post_params = params.fetch(:examples_post, {})
   def post_params_permitted
     post_params.permit(:title, :postable_type, link_attributes: [:url], image_attributes: [:url], markdown_attributes: [:body])
   end
+
+  def feature_enabled!
+    return if user_signed_in? &&
+      Flipper.enabled?(:example_posts, current_user)
+
+    raise ActionController::RoutingError.new("Not Found")
+  end
 end

spec/requests/examples/posts_spec.rb

@@ -2,9 +2,39 @@
 
 RSpec.describe "Examples::Posts", type: :request do
   describe "GET /index" do
-    it "is successful" do
-      get examples_posts_path
-      expect(response).to have_http_status(:success)
+    context "feature enabled" do
+      before do
+        user = login_user
+        Flipper.enable(:example_posts, user)
+      end
+
+      it "is successful" do
+        get examples_posts_path
+        expect(response).to have_http_status(:success)
+      end
+    end
+
+    context "user not authenticated" do
+      before do
+        Flipper.enable(:example_posts)
+      end
+
+      it "is not found" do
+        get examples_posts_path
+        expect(response).to have_http_status(:not_found)
+      end
+    end
+
+    context "feature disabled" do
+      before do
+        login_user
+        Flipper.disable(:example_posts)
+      end
+
+      it "is not found" do
+        get examples_posts_path
+        expect(response).to have_http_status(:not_found)
+      end
     end
   end
 end

spec/support/warden_helpers.rb

@@ -1,10 +1,12 @@
 module WardenHelpers
   def login_admin_user(admin_user = FactoryBot.create(:admin_user))
     login_as(admin_user, scope: :admin_user)
+    admin_user
   end
 
   def login_user(user = FactoryBot.create(:user))
     login_as(user, scope: :user)
+    user
   end
 end
 

spec/system/examples/posts_spec.rb

@@ -1,12 +1,17 @@
 require "rails_helper"
 
 RSpec.describe "Examples: Posts", type: :system do
+  before do
+    user = login_user
+    Flipper.enable(:example_posts, user)
+  end
+
   it "renders the form inputs dynamically and retains previously entered values" do
     visit examples_posts_path
 
     click_link "New Post"
 
-    within "form" do
+    within "main form" do
       expect(page).to have_content("Title")
       expect(page).to have_content("Text (Markdown)")
 
@@ -18,7 +23,7 @@
 
     choose "Link"
 
-    within "form" do
+    within "main form" do
       expect(page).to have_content("Title")
       expect(page).to have_content("Link URL")
 
@@ -29,7 +34,7 @@
 
     choose "Image"
 
-    within "form" do
+    within "main form" do
       expect(page).to have_content("Title")
       expect(page).to have_content("Image URL")
 
@@ -40,7 +45,7 @@
 
     choose "Text"
 
-    within "form" do
+    within "main form" do
       expect(page).to have_content("Title")
       expect(page).to have_content("Markdown")
 
@@ -52,14 +57,14 @@
 
     choose "Link"
 
-    within "form" do
+    within "main form" do
       expect(page).to have_field("Title", with: "My Post 🎸")
       expect(page).to have_field("Link URL", with: "https://example.com/link")
     end
 
     choose "Image"
 
-    within "form" do
+    within "main form" do
       expect(page).to have_field("Title", with: "My Post 🎸")
       expect(page).to have_field("Image URL", with: "https://example.com/image.jpg")
     end
@@ -70,7 +75,7 @@
 
     click_link "New Post"
 
-    within "form" do
+    within "main form" do
       fill_in "Title", with: "My Post 🎸"
       fill_in "Text (Markdown)", with: "# This is a post about guitars 🎸"
 
@@ -88,7 +93,7 @@
 
     choose "Link"
 
-    within "form" do
+    within "main form" do
       fill_in "Title", with: "My Link 🎸"
       fill_in "Link URL", with: "https://example.com/link"
 
@@ -106,7 +111,7 @@
 
     choose "Image"
 
-    within "form" do
+    within "main form" do
       fill_in "Title", with: "My Image 🎸"
       fill_in "Image URL", with: "https://example.com/image.jpg"