Skip to content

Commit 313ef2c

Browse files
committed
Update tests to avoid name collision for color schemes
1 parent 4c37be6 commit 313ef2c

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

spec/factories/color_schemes.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
FactoryBot.define do
44
factory :color_scheme do
5-
name { Faker::Color.color_name.titleize }
5+
sequence(:name) { |n| "#{Faker::Color.color_name.titleize} #{n}" }
66
weight_50 { Faker::Color.hex_color }
77
weight_100 { Faker::Color.hex_color }
88
weight_200 { Faker::Color.hex_color }

spec/requests/settings/color_schemes_spec.rb

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,13 @@
33
RSpec.describe "Settings Color Schemes", type: :request do
44
let(:default_color_scheme) { ColorScheme.find_or_create_default }
55
let(:curated_colors) do
6-
curated_color_names = YAML.load_file(Rails.root.join("config", "curated_colors.yml")).sample(3)
7-
8-
curated_color_names.map do |name|
9-
FactoryBot.create(:color_scheme, name: name)
10-
end
6+
FactoryBot.create_list(:color_scheme, 3)
117
end
128

139
before do
1410
default_color_scheme
15-
curated_colors
11+
12+
allow(ColorScheme).to receive(:curated).and_return(curated_colors)
1613
end
1714

1815
describe "GET color_schemes#show" do

spec/system/settings/color_schemes_spec.rb

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,12 @@
44

55
RSpec.describe "Customize Color Scheme", type: :system do
66
let(:curated_colors) do
7-
curated_color_names = YAML.load_file(Rails.root.join("config", "curated_colors.yml")).sample(3)
8-
9-
curated_color_names.map do |name|
10-
FactoryBot.create(:color_scheme, name: name)
11-
end
7+
FactoryBot.create_list(:color_scheme, 3)
128
end
139

14-
before { curated_colors }
10+
before do
11+
allow(ColorScheme).to receive(:curated).and_return(curated_colors)
12+
end
1513

1614
it "user can selected a curated color scheme" do
1715
visit settings_color_scheme_path

0 commit comments

Comments
 (0)