Remove feature gate on confirmation actions

Author: rossta

app/controllers/users/confirmations_controller.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 class Users::ConfirmationsController < ApplicationController
-  before_action :feature_enabled!
   before_action :redirect_if_authenticated, only: [:create, :new]
 
   def new
@@ -51,19 +50,15 @@ def update
     end
 
     if @user.confirm!
-      warden.set_user(@user, scope: :user)
+      if Flipper.enabled?(:user_registration, @user)
+        warden.set_user(@user, scope: :user)
+      end
 
       WelcomeNotifier.deliver_to(@user)
 
-      redirect_to users_dashboard_path, notice: "Thank you for confirming your email address"
+      redirect_to users_thank_you_path, notice: "Thank you for confirming your email address"
     else
       redirect_to new_users_confirmation_path, alert: "Something went wrong"
     end
   end
-
-  private
-
-  def feature_enabled!
-    redirect_to root_path, notice: "Coming soon!" unless Flipper.enabled?(:user_registration, current_admin_user)
-  end
 end

spec/requests/users/confirmations_spec.rb

@@ -5,10 +5,6 @@
 RSpec.describe "Confirmations", type: :request do
   include ActiveSupport::Testing::TimeHelpers
 
-  before do
-    Flipper[:user_registration].enable
-  end
-
   describe "POST create" do
     it "succeeds for unconfirmed user" do
       user = FactoryBot.create(:user, :unconfirmed)
@@ -103,7 +99,18 @@
 
       put users_confirmation_path(user.generate_token_for(:confirmation))
 
-      expect(response).to redirect_to(users_dashboard_path)
+      expect(response).to redirect_to(users_thank_you_path)
+      expect(flash[:notice]).to eq("Thank you for confirming your email address")
+    end
+
+    it "works when user sessions are disabled" do
+      Flipper[:user_registration].enable
+
+      user = FactoryBot.create(:user, :unconfirmed)
+
+      put users_confirmation_path(user.generate_token_for(:confirmation))
+
+      expect(response).to redirect_to(users_thank_you_path)
       expect(flash[:notice]).to eq("Thank you for confirming your email address")
     end