Email admin users for new subscribers

Author: rossta

app/controllers/users/newsletter_subscriptions_controller.rb

@@ -38,10 +38,10 @@ def create
       return render Users::NewsletterSubscriptions::NewView.new(newsletter_subscription: @newsletter_subscription), status: :unprocessable_entity
     end
 
-    if @user.needs_confirmation?
+    if @user.previously_new_record?
+      NewUserNotificationJob.perform_later(@user)
+    elsif @user.needs_confirmation?
       EmailConfirmationNotifier.deliver_to(@user)
-    else
-      # TODO: Send already subscribed email
     end
 
     redirect_to users_newsletter_subscription_path(@newsletter_subscription)

spec/requests/users/newsletter_subscriptions_spec.rb

@@ -80,6 +80,20 @@
       expect(mail.subject).to eq "Confirm your email address"
     end
 
+    it "notifies admin for new user" do
+      email = FactoryBot.generate(:email)
+      admin = FactoryBot.create(:admin_user)
+
+      post users_newsletter_subscriptions_path,
+        params: {user: {email: email, password: "password", password_confirmation: "password"}}
+
+      perform_enqueued_jobs_and_subsequently_enqueued_jobs
+
+      mail = find_mail_to(admin.email)
+
+      expect(mail.subject).to eq "New Joy of Rails User"
+    end
+
     it "disallows for a subscribing with an already subscribed email" do
       user = FactoryBot.create(:user, :subscribed)
 
@@ -94,7 +108,7 @@
       # assert "already subscribed" email sent
     end
 
-    it "succeeds for a user with existing accout who is not currently subscribed email" do
+    it "succeeds for a user with existing account who is not currently subscribed email" do
       user = FactoryBot.create(:user, :unsubscribed)
 
       expect {
@@ -107,6 +121,28 @@
       expect(user.reload.newsletter_subscription).to be_present
     end
 
+    it "sends confirmation for an unconfirmed user with existing account who is not currently subscribed email" do
+      user = FactoryBot.create(:user, :unsubscribed, :unconfirmed)
+      admin = FactoryBot.create(:admin_user)
+
+      expect {
+        post users_newsletter_subscriptions_path,
+          params: {user: {email: user.email}}
+      }.to change(NewsletterSubscription, :count).by(1)
+
+      expect(response).to redirect_to(users_newsletter_subscription_path(User.last.newsletter_subscription))
+
+      expect(user.reload.newsletter_subscription).to be_present
+
+      perform_enqueued_jobs_and_subsequently_enqueued_jobs
+
+      mail = find_mail_to(user.email)
+
+      expect(mail.subject).to eq "Confirm your email address"
+
+      expect(find_mail_to(admin.email)).to be_nil
+    end
+
     it "disallows a user to subscribe with an invalid email" do
       expect {
         post users_newsletter_subscriptions_path,