Implement public actions to view newsletters

Author: rossta

app/controllers/newsletters_controller.rb

@@ -0,0 +1,9 @@
+class NewslettersController < ApplicationController
+  def index
+    @newsletters = Newsletter.sent
+  end
+
+  def show
+    @newsletter = Newsletter.find(params[:id])
+  end
+end

app/models/newsletter.rb

@@ -1,4 +1,6 @@
 class Newsletter < ApplicationRecord
   validates :title, presence: true
   validates :content, presence: true
+
+  scope :sent, -> { where.not(sent_at: nil).order(sent_at: :desc) }
 end

app/views/newsletters/_newsletter.html.erb

@@ -0,0 +1,3 @@
+<div id="<%= dom_id newsletter %>" class="joy-border p-4">
+  <%= basic_markdown (newsletter&.content || "").html_safe %>
+</div>

app/views/newsletters/index.html.erb

@@ -0,0 +1,17 @@
+<%= render Pages::Header.new(title: "Joy of Rails Newsletter") %>
+<div class="section-content container py-gap">
+  <div class="only:inherit grid grid-row-mid">
+    <h2>No newsletters have been sent yet!</h2>
+    <div>
+      <p>Coming soon ;)</p>
+    </div>
+  </div>
+  <% @newsletters.each do |newsletter| %>
+    <div id="dom_id(newsletter)">
+      <h2><%= link_to newsletter.title, newsletter %></h2>
+      <div>
+        <p><%= time_tag newsletter.sent_at.to_date %></p>
+      </div>
+    </div>
+  <% end %>
+</div>

app/views/newsletters/show.html.erb

@@ -0,0 +1,4 @@
+<%= render Pages::Header.new(title: @newsletter.title, published_on: @newsletter.sent_at&.to_date) %>
+<div class="section-content container py-gap">
+  <%= render @newsletter %>
+</div>

config/routes.rb

@@ -10,18 +10,15 @@
   sitepress_root controller: :site
   sitepress_pages controller: :site
 
+  resources :newsletters, only: [:index, :show]
+
   namespace :examples do
     resource :counters, only: [:show, :update, :destroy]
     resource :hello, only: [:show]
     resources :posts, only: [:index, :create, :new]
   end
   resources :examples, only: [:index, :show]
 
-  namespace :pwa do
-    resource :installation_instructions, only: [:show]
-    resources :web_pushes, only: [:create]
-  end
-
   resources :feed, only: [:index], format: "atom"
 
   resources :color_schemes, only: [:index, :show]
@@ -35,6 +32,11 @@
     resource :syntax_highlight, only: [:show, :update]
   end
 
+  namespace :pwa do
+    resource :installation_instructions, only: [:show]
+    resources :web_pushes, only: [:create]
+  end
+
   namespace :users do
     resource :thank_you, only: [:show]
     resource :header_navigation, only: [:show]

spec/requests/admin/newsletters_spec.rb

@@ -1,17 +1,5 @@
 require "rails_helper"
 
-# This spec was generated by rspec-rails when you ran the scaffold generator.
-# It demonstrates how one might use RSpec to test the controller code that
-# was generated by Rails when you ran the scaffold generator.
-#
-# It assumes that the implementation code is generated by the rails scaffold
-# generator. If you are using any extension libraries to generate different
-# controller code, this generated spec may or may not pass.
-#
-# It only uses APIs available in rails and/or rspec-rails. There are a number
-# of tools you can use to make these specs even more expressive, but we're
-# sticking to rails and rspec-rails APIs to keep things simple and stable.
-
 RSpec.describe "/admin/newsletters", type: :request do
   let(:valid_attributes) { FactoryBot.attributes_for(:newsletter) }
   let(:invalid_attributes) { {title: "", content: ""} }
@@ -110,6 +98,101 @@
     end
   end
 
+  describe "PATCH /deliver" do
+    before do
+      allow(PostmarkClient).to receive(:deliver_messages)
+    end
+
+    context "with no parameters" do
+      before do
+        FactoryBot.create(:user, :confirmed, :subscribed, email: ApplicationMailer.test_recipients.first)
+        FactoryBot.create_list(:user, 2, :confirmed, :subscribed)
+      end
+
+      it "sends test email" do
+        newsletter = FactoryBot.create(:newsletter)
+        patch deliver_admin_newsletter_path(newsletter)
+        perform_enqueued_jobs_and_subsequently_enqueued_jobs
+        newsletter.reload
+        expect(newsletter.sent_at).to be_blank
+        expect(PostmarkClient).to have_received(:deliver_messages) do |messages|
+          expect(messages.size).to eq(1)
+          expect(messages.first.to).to eq(User.test_recipients.map(&:email))
+        end
+      end
+
+      it "redirects to the admin_newsletter" do
+        newsletter = FactoryBot.create(:newsletter)
+        patch deliver_admin_newsletter_path(newsletter)
+        newsletter.reload
+        expect(response).to redirect_to(admin_newsletter_path(newsletter))
+      end
+    end
+
+    context "with live parameter" do
+      before do
+        FactoryBot.create_list(:user, 2, :confirmed, :subscribed)
+      end
+
+      it "sends emails to subscribers" do
+        newsletter = FactoryBot.create(:newsletter)
+        patch deliver_admin_newsletter_path(newsletter), params: {live: "true"}
+        perform_enqueued_jobs_and_subsequently_enqueued_jobs
+        newsletter.reload
+        expect(newsletter.sent_at).to be_present
+        expect(PostmarkClient).to have_received(:deliver_messages) do |messages|
+          expect(messages.size).to eq(2)
+          expect(messages.flat_map(&:to)).to eq(User.subscribers.map(&:email))
+        end
+      end
+
+      it "redirects to the admin_newsletter" do
+        newsletter = FactoryBot.create(:newsletter)
+        patch deliver_admin_newsletter_path(newsletter), params: {live: "true"}
+        newsletter.reload
+        expect(response).to redirect_to(admin_newsletter_path(newsletter))
+      end
+    end
+
+    context "with no recipients" do
+      it "does not send any emails" do
+        newsletter = FactoryBot.create(:newsletter)
+        patch deliver_admin_newsletter_path(newsletter), params: {live: "true"}
+        perform_enqueued_jobs_and_subsequently_enqueued_jobs
+        newsletter.reload
+        expect(PostmarkClient).not_to have_received(:deliver_messages)
+      end
+
+      it "redirects to the admin_newsletter" do
+        newsletter = FactoryBot.create(:newsletter)
+        patch deliver_admin_newsletter_path(newsletter), params: {live: "true"}
+        newsletter.reload
+        expect(response).to redirect_to(admin_newsletter_path(newsletter))
+      end
+    end
+
+    context "newsletter is already sent" do
+      before do
+        FactoryBot.create_list(:user, 2, :subscribed)
+      end
+
+      it "does not send any emails" do
+        newsletter = FactoryBot.create(:newsletter)
+        patch deliver_admin_newsletter_path(newsletter), params: {live: "true"}
+        perform_enqueued_jobs_and_subsequently_enqueued_jobs
+        newsletter.reload
+        expect(PostmarkClient).not_to have_received(:deliver_messages)
+      end
+
+      it "redirects to the admin_newsletter" do
+        newsletter = FactoryBot.create(:newsletter)
+        patch deliver_admin_newsletter_path(newsletter), params: {live: "true"}
+        newsletter.reload
+        expect(response).to redirect_to(admin_newsletter_path(newsletter))
+      end
+    end
+  end
+
   describe "DELETE /destroy" do
     it "destroys the requested admin_newsletter" do
       newsletter = FactoryBot.create(:newsletter)

spec/requests/newsletter_spec.rb

@@ -0,0 +1,29 @@
+require "rails_helper"
+
+RSpec.describe "/newsletters", type: :request do
+  describe "GET /" do
+    it "renders a successful response" do
+      FactoryBot.create_list(:newsletter, 2)
+
+      get newsletters_path
+
+      expect(response).to be_successful
+    end
+
+    it "renders a successful without newsletters" do
+      get newsletters_path
+
+      expect(response).to be_successful
+    end
+  end
+
+  describe "GET /show" do
+    it "renders a successful response" do
+      newsletter = FactoryBot.create(:newsletter)
+
+      get newsletter_path(newsletter)
+
+      expect(response).to be_successful
+    end
+  end
+end