Ensure lazy page poll doesn’t blow up search index

Author: rossta

app/views/share/polls/lazy_page_poll.rb

@@ -13,8 +13,20 @@ def initialize(page, title, question_data = {})
       end
 
       def view_template
-        poll = Poll.generate_for(page, title, question_data) or return
-        turbo_frame_tag poll, src: share_poll_path(poll), class: "poll joy-border-subtle rounded"
+        if render?
+          turbo_frame_tag poll, src: share_poll_path(poll), class: "poll joy-border-subtle rounded"
+        end
+      end
+
+      private
+
+      def render?
+        !!page && !!poll
+      end
+
+      def poll
+        return @poll if defined?(@poll)
+        @poll = Poll.generate_for(page, title, question_data)
       end
     end
   end

spec/jobs/pages/refresh_search_index_job_spec.rb

@@ -1,7 +1,13 @@
 require "rails_helper"
 
 RSpec.describe Pages::RefreshSearchIndexJob, type: :job do
-  it "doesn’t blow up" do
+  it "doesn’t blow up when indexing the current pages" do
+    Page.upsert_collection_from_sitepress!
+
+    expect { described_class.perform_now }.not_to raise_error
+  end
+
+  it "indexes the right stuff" do
     page_1 = FactoryBot.create(:page, :published, request_path: "/articles/introducing-joy-of-rails")
     page_2 = FactoryBot.create(:page, :published, request_path: "/articles/custom-color-schemes-with-ruby-on-rails")
     page_3 = FactoryBot.create(:page, :unpublished, request_path: "/articles/joy-of-rails-2")