Inline SVG id generator consistency is now enabled for all tests

Author: rossta

lib/html_fixtures/patches/inline_svg_id_generator_randomness_override.rb

@@ -0,0 +1,20 @@
+module HtmlFixtures
+  module Patches
+    module InlineSvgIdGeneratorRandomnessOverride
+      def call
+        "non-random-for-fixtures"
+      end
+    end
+  end
+end
+
+# We use this module to override the randomness of the InlineSvg gem to ensure that the SVG
+# IDs are consistent across test runs and git commits in the generated HTML fixtures.
+#
+# Overrides this behavior: https://github.com/jamesmartin/inline_svg/blob/9ab5ccf8d4ba6a6d1e453d9bde2008a6ebab9877/lib/inline_svg/id_generator.rb#L5-L10
+#
+class InlineSvg::IdGenerator::Randomness
+  class << self
+    prepend HtmlFixtures::Patches::InlineSvgIdGeneratorRandomnessOverride
+  end
+end

lib/html_fixtures/renderer.rb

@@ -22,21 +22,9 @@ def build_view_context
       instance.set_response! ApplicationController.make_response!(request)
       instance.view_context
     end
-  end
-end
-
-# We need to override the randomness of the InlineSvg gem to ensure that the SVG
-# IDs are consistent across test runs and git commits.
-module InlineSvgIdGeneratorRandomnessOverrideForFixtures
-  def call
-    "non-random-for-fixtures"
-  end
-end
 
-if Rails.env.local?
-  class InlineSvg::IdGenerator::Randomness
-    class << self
-      prepend InlineSvgIdGeneratorRandomnessOverrideForFixtures
+    def self.ensure_inline_svg_id_consistency!
+      require_relative "patches/inline_svg_id_generator_randomness_override"
     end
   end
 end

lib/tasks/fixtures/html.rake

@@ -2,6 +2,7 @@ namespace :fixtures do
   task html: :environment do
     require_relative "../../html_fixtures/renderer"
 
+    HtmlFixtures::Renderer.ensure_inline_svg_id_consistency!
     HtmlFixtures::Renderer.new.render_all
   end
 end

spec/lib/html_fixtures/renderer_spec.rb

@@ -0,0 +1,10 @@
+require "rails_helper"
+
+RSpec.describe HtmlFixtures::Renderer do
+  it "renders all fixtures" do
+    HtmlFixtures::Renderer.new.render_all
+
+    expect(File.exist?(Rails.root.join("app", "javascript", "test", "fixtures", "views", "darkmode", "switch.html"))).to be true
+    expect(File.exist?(Rails.root.join("app", "javascript", "test", "fixtures", "views", "searches", "combobox.html"))).to be true
+  end
+end

spec/support/inline_svg.rb

@@ -0,0 +1 @@
+HtmlFixtures::Renderer.ensure_inline_svg_id_consistency!