Extract Page upsert method

Author: rossta

app/jobs/pages/batch_upsert_pages_job.rb

@@ -2,15 +2,8 @@ module Pages
   class BatchUpsertPagesJob < ApplicationJob
     queue_as :default
 
-    def perform
-      [
-        SitepressArticle,
-        SitepressSlashPage
-      ].each do |sitepress_collection|
-        sitepress_collection.all.each do |sitepress_resource|
-          Page.find_or_create_by!(request_path: sitepress_resource.request_path)
-        end
-      end
+    def perform(limit: nil)
+      Page.upsert_from_sitepress!(limit: limit)
     end
   end
 end

app/models/page.rb

@@ -30,10 +30,35 @@ def data = NullData.new(title: nil, description: nil)
   # def resource_data
   delegate :data, to: :resource, allow_nil: true, prefix: true
 
+  # We currently have a split system of Sitepress and Page models for handling static pages
+  # While not ideal, it currently allows us to live in both worlds depending on the context.
+  # Ultimately, migrating away from Sitepress for indexed content may be what‘s needed, but
+  # keeping the split personality for now.
   def self.as_published_articles
     SitepressArticle.take_published(all.map { |page| SitepressArticle.new(page.resource) })
   end
 
+  def self.upsert_from_sitepress!(limit: nil)
+    # Targeting specific Sitepress models until we have a better way to make
+    # Page model aware of published state
+    enum = [
+      SitepressArticle,
+      SitepressSlashPage
+    ].lazy.flat_map { |model| model.all.resources }
+
+    enum = enum.filter do |sitepress_resource|
+      Page.find_by(request_path: sitepress_resource.request_path).nil?
+    end.map do |sitepress_resource|
+      Page.create!(request_path: sitepress_resource.request_path)
+    end
+
+    if limit
+      enum = enum.take(limit)
+    end
+
+    enum.to_a
+  end
+
   def sitepress_article
     SitepressArticle.new(resource)
   end

spec/jobs/pages/batch_upsert_pages_job_spec.rb

@@ -19,4 +19,14 @@
       described_class.perform_now
     }.not_to change(Page, :count)
   end
+
+  it "handles limit argument" do
+    expect {
+      described_class.perform_now(limit: 3)
+    }.to change(Page, :count).by(3)
+
+    expect {
+      described_class.perform_now(limit: 3)
+    }.to change(Page, :count).by(3)
+  end
 end