Skip to content

Commit 98fcd1e

Browse files
authored
Merge pull request #189 from joyofrails/chore/style-updates
Fix for Newsletter edit preview
2 parents cdcc7d0 + 79ba77a commit 98fcd1e

File tree

6 files changed

+11
-3
lines changed

6 files changed

+11
-3
lines changed

app/controllers/admin/newsletters_controller.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ def new
1717
# GET /admin/newsletters/1/edit
1818
def edit
1919
@newsletter = Newsletter.find(params[:id])
20+
@newsletter.assign_attributes(newsletter_params)
2021
end
2122

2223
# POST /admin/newsletters

app/javascript/css/utilities/custom.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@
2626
padding-bottom: var(--space-3xl);
2727
}
2828

29+
.mx--4 {
30+
margin-left: -1rem;
31+
margin-right: -1rem;
32+
}
33+
2934
.bg-success {
3035
background-color: var(--joy-background-success);
3136
}

app/views/admin/newsletters/_form.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<fieldset>
2525
<%= form.submit class: "button primary" %>
2626
<%= form.submit "Preview", class: "button secondary",
27-
formaction: new_admin_newsletter_path,
27+
formaction: (newsletter.persisted? ? edit_admin_newsletter_path(newsletter) : new_admin_newsletter_path),
2828
formmethod: "get",
2929
formnovalidate: true,
3030
data: { turbo_frame: dom_id(newsletter, :markdown) } %>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<div id="<%= dom_id newsletter %>" class="joy-border p-4">
1+
<div id="<%= dom_id(newsletter, :markdown) %>" class="article-content joy-border-subtle p-4 mx--4">
22
<%= basic_markdown (newsletter&.content || "").html_safe %>
33
</div>

app/views/admin/newsletters/show.html.erb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@
44
<%= button_to "Send Test", deliver_admin_newsletter_path(@newsletter), method: :patch, class: "button secondary" %>
55
<%= button_to "Send Live", deliver_admin_newsletter_path(@newsletter, live: true), method: :patch, class: "button primary" %>
66
</div>
7+
<hr>
78

89
<%= render @newsletter %>
910

11+
<hr>
1012
<div class="flex col-gap-m">
1113
<%= link_to "Back to newsletters", admin_newsletters_path %>
1214
<%= link_to "Public Show", @newsletter %>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<div id="<%= dom_id newsletter %>" class="joy-border p-4">
1+
<div id="<%= dom_id newsletter %>" class="article-content">
22
<%= basic_markdown (newsletter&.content || "").html_safe %>
33
</div>

0 commit comments

Comments
 (0)