Allow public access for Snippets show and index pages

Author: rossta

app/controllers/share/snippets_controller.rb

@@ -1,7 +1,7 @@
 class Share::SnippetsController < ApplicationController
   using Refinements::Emojoy
 
-  before_action :feature_enabled!
+  before_action :feature_enabled!, except: %i[index show]
   before_action :authenticate_user!, only: %i[new create edit update destroy]
 
   # GET /snippets

app/views/share/snippets/index.html.erb

@@ -1,8 +1,10 @@
 <%= render Pages::Header.new(title: "Snippet Share") %>
 <div id="snippets" class="section-content container py-gap">
-  <div class="flex">
-    <%= link_to "New snippet", new_share_snippet_path, class: "button primary" %>
-  </div>
+  <% if Flipper.enabled?(:snippets, current_user) %>
+    <div class="flex">
+      <%= link_to "New Snippet", new_share_snippet_path, class: "button primary" %>
+    </div>
+  <% end %>
 
   <% @snippets.each do |snippet| %>
     <%= link_to share_snippet_path(snippet), class: "block" do %>

spec/requests/share/snippets_spec.rb

@@ -3,18 +3,27 @@
 RSpec.describe "/snippets", type: :request do
   describe "GET /index" do
     it "renders a successful response" do
-      Flipper.enable(:snippets, login_as_user)
-
       FactoryBot.create(:snippet)
       get share_snippets_url
       expect(response).to be_successful
     end
+
+    it "does render the New Snippet button when not allowed" do
+      get share_snippets_url
+
+      expect(page).to_not have_content("New Snippet")
+    end
+
+    it "renders the New Snippet button when allowed" do
+      Flipper.enable(:snippets, login_as_user)
+      get share_snippets_url
+
+      expect(page).to have_content("New Snippet")
+    end
   end
 
   describe "GET /show" do
     it "renders a successful response" do
-      Flipper.enable(:snippets, login_as_user)
-
       snippet = FactoryBot.create(:snippet)
       get share_snippet_url(snippet)
       expect(response).to be_successful

spec/support/requests.rb

@@ -1,8 +1,16 @@
+module RequestSpecHelpers
+  def page
+    @page ||= Capybara.string(response.body)
+  end
+end
+
 RSpec.configure do |config|
   config.include Warden::Test::Helpers, type: :request
   config.include Rails.application.routes.url_helpers, type: :request
 
   config.before(:each, type: :request) do
     host! "example.com"
   end
+
+  config.include RequestSpecHelpers, type: :request
 end

spec/system/snippets_spec.rb

@@ -10,7 +10,7 @@
 
     visit share_snippets_path
 
-    click_link "New snippet"
+    click_link "New Snippet"
 
     fill_in "snippet[filename]", with: "app/models/blog.rb"
     select "Ruby", from: "Language"