Skip to content

Commit afa5e47

Browse files
committed
Remove plausible event from color scheme controller
Needs investigation: events triggered from backend have not been consistently showing up in plausible.
1 parent 9835023 commit afa5e47

File tree

2 files changed

+0
-31
lines changed

2 files changed

+0
-31
lines changed

app/controllers/settings/color_schemes_controller.rb

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
class Settings::ColorSchemesController < ApplicationController
2-
after_action :send_plausible_event, only: :update
3-
42
def show
53
@color_scheme = find_color_scheme
64

@@ -45,23 +43,4 @@ def update
4543

4644
redirect_to settings_color_scheme_path, status: :see_other
4745
end
48-
49-
private
50-
51-
def send_plausible_event
52-
plausible_event "Color Scheme Update", props: {color_scheme: @color_scheme.name}
53-
end
54-
55-
def plausible_event(name, props: {})
56-
Analytics::PlausibleEventJob.perform_later(
57-
name: name,
58-
url: request.original_url,
59-
props: props,
60-
referrer: request.referer,
61-
headers: {
62-
"User-Agent" => request.user_agent,
63-
"X-Forwarded-For" => request.remote_ip
64-
}
65-
)
66-
end
6746
end

spec/requests/settings/color_schemes_spec.rb

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -106,15 +106,5 @@
106106
expect(response.body).to match("--color-#{default_color_scheme.name.parameterize}")
107107
end
108108
end
109-
110-
it "sends a plausible event" do
111-
plausible_request = stub_request(:post, "https://plausible.io/api/event")
112-
113-
patch settings_color_scheme_path(settings: {color_scheme_id: color_scheme.id})
114-
115-
perform_enqueued_jobs
116-
117-
expect(plausible_request).to have_been_requested
118-
end
119109
end
120110
end

0 commit comments

Comments
 (0)