Add newsletter index route for current user

Author: rossta

app/controllers/users/newsletter_subscriptions_controller.rb

@@ -1,13 +1,13 @@
 class Users::NewsletterSubscriptionsController < ApplicationController
   invisible_captcha only: [:create]
 
-  # TODO: Implement singular resource index action for logged in user
-  # before_action :authenticate_user!, only: [:index]
+  before_action :authenticate_user_or_not_found!, only: [:index]
 
-  # def index
-  #   @newsletter_subscription = current_user.newsletter_subscription || current_user.build_newsletter_subscription
-  #   render :show
-  # end
+  def index
+    @newsletter_subscription = current_user.newsletter_subscription || current_user.build_newsletter_subscription
+
+    render Users::NewsletterSubscriptions::ShowView.new(newsletter_subscription: @newsletter_subscription)
+  end
 
   def show
     @newsletter_subscription = NewsletterSubscription.find(params[:id]) or raise ActiveRecord::RecordNotFound
@@ -59,7 +59,7 @@ def unsubscribe
       # all because has_one is not enforced as a constraint
       NewsletterSubscription.where(subscriber: current_user).destroy_all
     else
-      raise ActiveRecord::RecordNotFound
+      not_found!
     end
 
     if request.post? && params["List-Unsubscribe"] == "One-Click"

config/routes.rb

@@ -37,7 +37,7 @@
     resources :confirmations, only: [:new, :create, :edit, :update], param: :token
     resources :passwords, only: [:new, :create, :edit, :update], param: :token
 
-    resources :newsletter_subscriptions, only: [:new, :create, :show]
+    resources :newsletter_subscriptions, only: [:new, :create, :index, :show]
     resources :newsletter_subscriptions, only: [], param: :token do
       match :unsubscribe, on: :collection, via: [:get, :post, :delete]
       match :unsubscribe, on: :member, via: [:get, :post, :delete]

spec/requests/users/newsletter_subscriptions_spec.rb

@@ -19,6 +19,45 @@
     end
   end
 
+  describe "GET show" do
+    it "succeeds for existing subscription" do
+      subscription = FactoryBot.create(:newsletter_subscription)
+      get users_newsletter_subscription_path(subscription)
+
+      expect(response).to have_http_status(:ok)
+    end
+
+    it "fails otherwise" do
+      get users_newsletter_subscription_path("not-found")
+
+      expect(response).to have_http_status(:not_found)
+    end
+  end
+
+  describe "GET index" do
+    it "succeeds for logged in user with subscription" do
+      login_user FactoryBot.create(:user, :subscribed)
+
+      get users_newsletter_subscriptions_path
+
+      expect(response).to have_http_status(:ok)
+    end
+
+    it "succeeds for logged in user without subscription" do
+      login_user FactoryBot.create(:user, :unsubscribed)
+
+      get users_newsletter_subscriptions_path
+
+      expect(response).to have_http_status(:ok)
+    end
+
+    it "requires authentication" do
+      get users_newsletter_subscriptions_path
+
+      expect(response).to have_http_status(:not_found)
+    end
+  end
+
   describe "POST create" do
     it "succeeds for unauthenticated request" do
       email = FactoryBot.generate(:email)