Refactor away from Current.page

I used Current.page as a quick-and-dirty workaround to be able to render
inline Polls in Sitepress articles from different contexts. Local
variables can be used instead and that’s what I’ve done here.

Author: rossta

app/content/layouts/article.html.erb

@@ -1,12 +1,11 @@
-<% page = @page %>
 <% set_meta_tags(
-     title: page.title,
-     description: page.description,
+     title: current_page.title,
+     description: current_page.description,
      keywords: %w[rails hotwire],
      og: {
        type: "article",
-       url: page.request_path,
-       image: page.meta_image && asset_url(page.meta_image)
+       url: current_page.request_path,
+       image: current_page.meta_image && asset_url(current_page.meta_image)
      },
      twitter: {
        card: "summary"
@@ -16,11 +15,11 @@
 <%= render_layout "application" do %>
   <article itemscope itemtype="http://schema.org/Article" class="mb-3xl">
     <%= render Pages::Header::Container.new do |c| %>
-      <%= c.title { page.title } %>
-      <%= c.description { page.description } if page.description %>
-      <%= render Pages::Timestamp.new published_on: page.published_on, updated_on: page.revised_on, class: "text-small block" %>
+      <%= c.title { current_page.title } %>
+      <%= c.description { current_page.description } if current_page.description %>
+      <%= render Pages::Timestamp.new published_on: current_page.published_on, updated_on: current_page.revised_on, class: "text-small block" %>
       <div class="text-small">
-        <% topics = @page.topics.approved.pluck(:slug) %>
+        <% topics = current_page.topics.approved.pluck(:slug) %>
         <% if topics.present? %>
           <%= render Pages::Topics.new(topics: topics) %>
         <% end %>
@@ -29,8 +28,8 @@
     <div class="article-content container" itemprop="articleBody">
       <%= yield %>
 
-      <% cache [@page, :related_pages] do %>
-        <% related_pages = @page.related_pages.published.limit(3) %>
+      <% cache [@current_page, :related_pages] do %>
+        <% related_pages = @current_page.related_pages.published.limit(3) %>
         <% if related_pages.present? %>
           <h3>More articles to enjoy</h3>
           <ul class="list-none">
@@ -54,6 +53,6 @@
   </section>
 <% end %>
 
-<% if page.enable_twitter_widgets %>
+<% if current_page.enable_twitter_widgets %>
 <%= javascript_include_tag "https://platform.twitter.com/widgets.js", charset: "utf-8", async: true %>
 <% end %>

app/content/pages/articles/what-you-need-to-know-about-sqlite.html.mdrb

@@ -17,7 +17,7 @@ It’s basically this: computers have gotten faster, and Rails has finally figur
 
 With the recent release of Rails 8, it’s easier than ever to choose SQLite as your primary database for production. The question is, _should you?_
 
-<%= render Share::Polls::LazyPagePoll.new(Current.page, "SQLite on Rails Live Poll", "How likely are you to use SQLite in your next Rails app?" => ["Definitely! 🎸", "Strongly considering 💪", "On the fence ⚖️", "Maybe, but not likely 👻", "No way 🚫"]) %>
+<%= render Share::Polls::LazyPagePoll.new(@current_page, "SQLite on Rails Live Poll", "How likely are you to use SQLite in your next Rails app?" => ["Definitely! 🎸", "Strongly considering 💪", "On the fence ⚖️", "Maybe, but not likely 👻", "No way 🚫"]) %>
 
 ## SQLite3::Database.open
 

app/content/pages/articles/zee-kitchen-sink-permanent-draft.html.mdrb

@@ -13,4 +13,4 @@ tags:
 
 ## Inline Poll Demo
 
-<%= render Share::Polls::LazyPagePoll.new(Current.page, "SQLite on Rails Poll", "How likely are you to use SQLite in your Rails app?" => ["100%", "Strongly considering", "On the fence", "Not very, but open minded", "No way"]) if Current.page %>
+<%= render Share::Polls::LazyPagePoll.new(current_page, "SQLite on Rails Poll", "How likely are you to use SQLite in your Rails app?" => ["100%", "Strongly considering", "On the fence", "Not very, but open minded", "No way"]) if current_page %>

app/content/pages/index.html.erb

@@ -9,7 +9,7 @@ title: Joy of Rails
       Experience the<br><span class="text-gradient">Joy of Ruby on Rails</span>
     <% end %>
     <p>
-      Interactive lessons to learn the framework that will make you fall in love with building web apps all over again 💜
+      Interactive lessons in the framework that will make you fall in love with building web apps all over again 💜
     </p>
   </div>
 <% end %>

app/controllers/concerns/current_page.rb

@@ -0,0 +1,11 @@
+module CurrentPage
+  extend ActiveSupport::Concern
+
+  included do
+    helper_method :current_page
+  end
+
+  def current_page
+    @current_page
+  end
+end

app/controllers/feed_controller.rb

@@ -1,4 +1,6 @@
 class FeedController < ApplicationController
+  include CurrentPage
+
   def index
     @articles = Page.published.order(published_at: :desc).limit(50)
 

app/controllers/site_controller.rb

@@ -1,13 +1,18 @@
 class SiteController < Sitepress::SiteController
+  include CurrentPage
+
+  before_action do
+    @current_page = Page.find_or_initialize_by(request_path: request.path)
+  end
+
   # This is the default controller for Sitepress. It is used to render the pages of the site.
   # We prefer not to override this method but instead use the hooks provided by Sitepress below.
   #
   # render_resource is a helper method provided by Sitepress to render the current resource.
   # requested_resource is the Sitepress::Resource object that represents the current page.
   #
-  def show
-    Current.page = @page = Page.find_or_initialize_by(request_path: request.path)
 
+  def show
     super
   end
 

app/models/current.rb

@@ -2,5 +2,4 @@ class Current < ActiveSupport::CurrentAttributes
   attribute :admin_user
   attribute :user
   attribute :color_scheme
-  attribute :page
 end

app/views/components/atom/entry_content.rb

@@ -54,6 +54,7 @@ def render_template_html
       layout: false,
       content_type: "application/atom+xml",
       assigns: {
+        current_page: article,
         format: :atom
       }
     )

app/views/feed/index.atom.builder

@@ -4,8 +4,6 @@ atom_feed do |feed|
 
   @articles.take(50).each do |article|
     next if article.resource_missing?
-    Current.page = article
-
     feed.entry(
       article,
       id: "tag:#{request.host},2005:article/#{article.atom_feed_id}",