Refactor stimulus tweet options

Author: rossta

app/javascript/controllers/snippets/tweet.ts

@@ -5,6 +5,22 @@ import debug from '../../utils/debug';
 
 const console = debug('app:javascript:controllers:snippets:tweet');
 
+const WINDOW_OPTIONS = {
+  width: 550,
+  height: 420,
+  toolbar: false,
+  location: false,
+  directories: false,
+  status: false,
+  menubar: false,
+  scrollbars: true,
+  copyhistory: false,
+  resizable: true,
+};
+
+const WINDOW_OPTIONS_ARGUMENT = Object.entries(WINDOW_OPTIONS)
+  .map(([key, value]) => `${key}=${value}`)
+  .join(',');
 export default class extends Controller {
   static values = {
     url: String,
@@ -32,10 +48,6 @@ export default class extends Controller {
 
     const tweetUrl = `https://x.com/intent/post?text=${tweetText}`;
 
-    window.open(
-      tweetUrl,
-      '_blank',
-      'width=550,height=420,toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=yes,copyhistory=no,resizable=yes',
-    );
+    window.open(tweetUrl, '_blank', WINDOW_OPTIONS_ARGUMENT);
   }
 }

app/views/share/snippets/toolbar.rb

@@ -21,7 +21,7 @@ def share_url
     if @snippet.screenshot.attached?
       new_share_snippet_tweet_path(@snippet, auto: "true")
     else
-      new_share_snippet_screenshot_path(@snippet)
+      new_share_snippet_screenshot_path(@snippet, auto: "true")
     end
   end
 end