Skip to content

Commit c29b518

Browse files
committed
Rework snippet css with 2/1 aspect ratio for Twitter
1 parent edd40fb commit c29b518

File tree

2 files changed

+39
-27
lines changed

2 files changed

+39
-27
lines changed

app/javascript/css/components/snippet.css

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
.snippet {
22
filter: drop-shadow(0 0 0.75rem var(--joy-color-50));
33
width: fit-content;
4-
max-width: var(--grid-max-width);
4+
max-width: var(--grid-max-width) - (2 * var(--grid-gutter));
55

66
& .code-editor {
77
padding-top: var(--space-xs);
@@ -15,7 +15,18 @@
1515
background-color: var(--joy-color-200);
1616
padding: var(--space-l);
1717
width: fit-content;
18+
aspect-ratio: 2 / 1;
1819
border-radius: 0.5rem;
20+
max-width: var(--grid-max-width);
21+
overflow-x: clip;
22+
23+
display: flex;
24+
flex-direction: column;
25+
justify-content: center;
26+
27+
& .code-wrapper {
28+
margin: 0 auto;
29+
}
1930
}
2031

2132
/*

app/views/share/snippets/form.rb

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -15,36 +15,34 @@ def initialize(snippet)
1515

1616
def view_template
1717
turbo_stream.update "flash", partial: "application/flash"
18-
div(class: "grid-content") do
18+
div(class: "section-content") do
1919
form_with(
2020
model: [:share, snippet],
21-
class: "grid-content",
21+
class: "section-content",
2222
data: {
2323
controller: "snippet-preview",
2424
action: "snippet-editor:edit-finish->snippet-preview#preview"
2525
}
2626
) do |form|
2727
errors
2828

29-
div(class: "grid-cols-12") do
30-
div(class: "snippet-background") do
31-
render CodeBlock::Container.new(language: language, class: "snippet") do
32-
render CodeBlock::Header.new do
33-
label(class: "sr-only", for: "snippet[filename]") { "Filename" }
34-
input(type: "text", name: "snippet[filename]", value: filename)
35-
end
29+
div(class: "snippet-background") do
30+
render CodeBlock::Container.new(language: language, class: "snippet") do
31+
render CodeBlock::Header.new do
32+
label(class: "sr-only", for: "snippet[filename]") { "Filename" }
33+
input(type: "text", name: "snippet[filename]", value: filename)
34+
end
3635

37-
turbo_frame_tag dom_id(snippet, :code_block) do
38-
render CodeBlock::Body.new(data: {controller: "snippet-editor"}) do
39-
div(class: "grid-stack") do
40-
render CodeBlock::Code.new(source, language: language, data: {snippet_editor_target: "source"})
41-
label(class: "sr-only", for: "snippet[source]") { "Source" }
42-
div(class: "code-editor autogrow-wrapper") do
43-
textarea(
44-
name: "snippet[source]",
45-
data: {snippet_editor_target: "textarea"}
46-
) { source }
47-
end
36+
turbo_frame_tag dom_id(snippet, :code_block) do
37+
render CodeBlock::Body.new(data: {controller: "snippet-editor"}) do
38+
div(class: "grid-stack") do
39+
render CodeBlock::Code.new(source, language: language, data: {snippet_editor_target: "source"})
40+
label(class: "sr-only", for: "snippet[source]") { "Source" }
41+
div(class: "code-editor autogrow-wrapper") do
42+
textarea(
43+
name: "snippet[source]",
44+
data: {snippet_editor_target: "textarea"}
45+
) { source }
4846
end
4947
end
5048
end
@@ -74,12 +72,15 @@ def view_template
7472
end
7573

7674
if @snippet.persisted?
77-
flex_block do
78-
button_to "Destroy this snippet",
79-
share_snippet_path(@snippet), method: :delete,
80-
data: {confirm: "Are you sure?"},
81-
class: "button warn",
82-
form: {style: "margin-left: auto"} # move to the right
75+
br
76+
div do
77+
flex_block do
78+
button_to "Destroy this snippet",
79+
share_snippet_path(@snippet), method: :delete,
80+
data: {confirm: "Are you sure?"},
81+
class: "button warn"
82+
# form: {style: "margin-left: auto"} # move to the right
83+
end
8384
end
8485
end
8586
end

0 commit comments

Comments
 (0)