Simplify footer html and css

Author: rossta

app/javascript/css/components/footer-content.css

@@ -3,7 +3,7 @@ footer {
 }
 
 .footer-content {
-  & nav > * {
+  & nav > ul > li {
     padding-top: var(--space-2xs-xs);
     padding-bottom: var(--space-2xs-xs);
   }
@@ -13,33 +13,14 @@ footer {
     flex-wrap: wrap;
   }
 
-  & nav > ul > li:first-child {
-    & a {
-      font-weight: bold;
-    }
-
-    &:has(+ li) {
-      margin-inline-end: var(--space-2xs-xs);
-
-      & a {
-        margin-inline-end: var(--space-2xs-xs);
-      }
-
-      &:after {
-        content: ' / ';
-        color: var(--joy-text-faint);
-      }
-    }
+  & nav > ul > li > a {
+    font-weight: bold;
   }
 
-  & nav > ul > li > ul > li:has(+ li) {
-    margin-inline-end: var(--space-2xs-xs);
-
-    & a {
-      margin-inline-end: var(--space-2xs-xs);
-    }
-
+  & nav li:has(+ li) {
     &:after {
+      margin-inline-start: var(--space-2xs-xs);
+      margin-inline-end: var(--space-2xs-xs);
       content: ' / ';
       color: var(--joy-text-faint);
     }

app/views/application/_footer.html.erb

@@ -4,51 +4,47 @@
       <div><%= inline_svg_tag "joy-logo.svg", class: "fill-current" %></div>
       <div>Sharing and experiencing the Joy of Rails</div>
     <% end %>
-    <nav
-      class="">
+    <nav>
       <ul>
-        <li class="">
-          <a
-            class=""
-            href="/articles">Articles</a>
-        </li>
-      </ul>
-      <ul>
-        <li class="">
-          <%= link_to "Settings", settings_color_scheme_path %>
-        </li>
-        <li class="">
-          <%= link_to "Syntax Highlighting", settings_syntax_highlight_path %>
-        </li>
-        <!--
         <li>
-          <ul>
-            <li>
-              <%#= link_to "Colors", settings_color_scheme_path %>
-            </li>
-          </ul>
+          <a href="/articles">Articles</a>
         </li>
-        -->
       </ul>
       <ul>
-        <li class="">
-          <a class="" href="/about">About</a>
+        <li>
+          <%= link_to "Settings", settings_color_scheme_path %>
         </li>
         <li>
           <ul>
             <li>
-              <a class="" href="/about/acknowledgements">Acknowledgements</a>
+              <%= link_to "Color Schemes", settings_color_scheme_path %>
             </li>
             <li>
-              <a class="" href="/about/design">Design</a>
+              <%= link_to "Syntax Highlighting", settings_syntax_highlight_path %>
             </li>
           </ul>
         </li>
       </ul>
-      <ul>
-        <li class=""><a
-            class=""
-            href="mailto:[email protected]">[email protected]</a></li>
+        <ul>
+          <li>
+            <a href="/about">About</a>
+          </li>
+          <li>
+            <ul>
+              <li>
+                <a class="" href="/about/acknowledgements">Acknowledgements</a>
+              </li>
+              <li>
+                <a class="" href="/about/design">Design</a>
+              </li>
+            </ul>
+          </li>
+        </ul>
+        <ul>
+          <li>
+            <a href="mailto:[email protected]">[email protected]</a>
+          </li>
+        </ul>
       </ul>
     </nav>
     <div>

spec/system/settings/color_schemes_spec.rb

@@ -14,7 +14,7 @@
   it "user can selected a curated color scheme" do
     visit root_path
 
-    click_link "Settings"
+    click_link "Color Schemes"
 
     chosen_color = curated_colors.sample
     select chosen_color.display_name, from: "settings[color_scheme_id]"