Skip to content

Commit de98ae3

Browse files
committed
Remove selenium-webdriver from Gemfile
1 parent b28edaa commit de98ae3

File tree

3 files changed

+15
-21
lines changed

3 files changed

+15
-21
lines changed

Gemfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,14 @@ end
5858

5959
group :test do
6060
gem "capybara" # Acceptance test framework for web applications [https://github.com/teamcapybara/capybara]
61-
gem "selenium-webdriver" # Ruby bindings for Selenium [https://www.rubydoc.info/gems/selenium-webdriver/frames]
6261
gem "cuprite" # Headless Chrome driver for Capybara [https://github.com/rubycdp/cuprite]
6362
gem "simplecov", require: false # Code coverage for Ruby [https://github.com/simplecov-ruby/simplecov]
6463
gem "simplecov-tailwindcss", require: false # Alternative HTML formatter for SimpleCov [https://github.com/chiefpansancolt/simplecov-tailwindcss]
6564
gem "simplecov-cobertura", require: false # Produces Cobertura formatted XML from SimpleCov. [https://github.com/dashingrocket/simplecov-cobertura]
6665
gem "webmock", require: false # Library for stubbing HTTP requests [https://github.com/bblimke/webmock]
66+
67+
# Uncomment the following line and bundle to use Selenium with Firefox
68+
# gem "selenium-webdriver" # Ruby bindings for Selenium [https://www.rubydoc.info/gems/selenium-webdriver/frames]
6769
end
6870

6971
group :development, :test do

Gemfile.lock

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,6 @@ GEM
257257
logfmt (>= 0.0.10)
258258
sqlite3
259259
logfmt (0.0.10)
260-
logger (1.6.0)
261260
loofah (2.22.0)
262261
crass (~> 1.0.2)
263262
nokogiri (>= 1.12.0)
@@ -428,16 +427,9 @@ GEM
428427
ruby-progressbar (1.13.0)
429428
ruby_wasm (2.6.2-arm64-darwin)
430429
ruby_wasm (2.6.2-x86_64-linux)
431-
rubyzip (2.3.2)
432430
sanitize (6.1.1)
433431
crass (~> 1.0.2)
434432
nokogiri (>= 1.12.0)
435-
selenium-webdriver (4.23.0)
436-
base64 (~> 0.2)
437-
logger (~> 1.4)
438-
rexml (~> 3.2, >= 3.2.5)
439-
rubyzip (>= 1.2.2, < 3.0)
440-
websocket (~> 1.0)
441433
sexp_processor (4.17.2)
442434
simplecov (0.22.0)
443435
docile (~> 1.1)
@@ -533,7 +525,6 @@ GEM
533525
crack (>= 0.3.2)
534526
hashdiff (>= 0.4.0, < 2.0.0)
535527
webrick (1.8.1)
536-
websocket (1.2.11)
537528
websocket-driver (0.7.6)
538529
websocket-extensions (>= 0.1.0)
539530
websocket-extensions (0.1.5)
@@ -586,7 +577,6 @@ DEPENDENCIES
586577
rouge
587578
rspec-rails
588579
ruby_wasm (~> 2.5)
589-
selenium-webdriver
590580
simplecov
591581
simplecov-cobertura
592582
simplecov-tailwindcss

spec/system/pwa_showcase_spec.rb

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,19 @@
1313
expect(page).to have_button("Install to Homescreen")
1414
end
1515

16-
context "firefox" do
17-
before do
18-
driven_by(:selenium, using: :headless_firefox)
19-
end
16+
# To run the following test, add selenium-webdriver to Gemfile
17+
#
18+
# context "firefox" do
19+
# before do
20+
# driven_by(:selenium, using: :headless_firefox)
21+
# end
2022

21-
it "renders the Install to Homescreen button" do
22-
visit "/pwa-showcase"
23+
# it "renders the Install to Homescreen button" do
24+
# visit "/pwa-showcase"
2325

24-
click_link "Install to Homescreen"
26+
# click_link "Install to Homescreen"
2527

26-
expect(page).to have_content("PWA installation is not currently supported in Firefox on desktop.")
27-
end
28-
end
28+
# expect(page).to have_content("PWA installation is not currently supported in Firefox on desktop.")
29+
# end
30+
# end
2931
end

0 commit comments

Comments
 (0)