Add more tests for newsletters

Author: rossta

app/controllers/admin/newsletters_controller.rb

@@ -42,13 +42,13 @@ def update
   # DELETE /admin/newsletters/1
   def destroy
     @newsletter.destroy!
-    redirect_to admin_newsletter_url, notice: "Newsletter was successfully destroyed.", status: :see_other
+    redirect_to admin_newsletters_path, notice: "Newsletter was successfully destroyed.", status: :see_other
   end
 
   # PATCH /admin/newsletters/1/deliver
   def deliver
     @newsletter = Newsletter.find(params[:id])
-    recipients = deliver_live? ? User.subscribers : User.where(email: ApplicationMailer.test_recipients)
+    recipients = deliver_live? ? User.subscribers : User.test_recipients
     label = deliver_live? ? "LIVE" : "TEST"
 
     if recipients.empty?

app/models/user.rb

@@ -11,6 +11,7 @@ class User < ApplicationRecord
   scope :confirmed, -> { where.not(confirmed_at: nil) }
   scope :recently_confirmed, -> { where("confirmed_at > ?", 2.weeks.ago) }
   scope :subscribers, -> { confirmed.joins(:newsletter_subscription) }
+  scope :test_recipients, -> { where(email: ApplicationMailer.test_recipients) }
 
   accepts_nested_attributes_for :email_exchanges, limit: 1
 

spec/mailers/emails/newsletter_mailer_spec.rb

@@ -0,0 +1,19 @@
+require "rails_helper"
+
+RSpec.describe Emails::NewsletterMailer, type: :mailer do
+  describe "#newsletter" do
+    let(:newsletter) { instance_double(Newsletter, title: "A Newsletter", content: Faker::Markdown.sandwich(sentences: 3)) }
+    let(:user) { instance_double(User, email: "[email protected]") }
+    let(:mail) { Emails::NewsletterMailer.newsletter(newsletter:, user:, unsubscribe_token: "token") }
+
+    it "renders the headers" do
+      expect(mail.subject).to eq("A Newsletter")
+      expect(mail.to).to eq(["[email protected]"])
+      expect(mail.from).to eq(["[email protected]"])
+    end
+
+    it "renders the body" do
+      expect(mail.body.encoded).to match(Markdown::Base.new(newsletter.content).call)
+    end
+  end
+end

spec/mailers/previews/emails/newsletter_mailer_preview.rb

@@ -0,0 +1,10 @@
+# Preview all emails at http://localhost:3000/rails/mailers/newsletter_mailer
+class Emails::NewsletterMailerPreview < ActionMailer::Preview
+  def newsletter
+    Emails::NewsletterMailer.newsletter(
+      newsletter: FactoryBot.build(:newsletter),
+      user: FactoryBot.build(:user),
+      unsubscribe_token: "unsubscribe_token"
+    )
+  end
+end

spec/models/newsletter_spec.rb

@@ -1,5 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Newsletter, type: :model do
-  pending "add some examples to (or delete) #{__FILE__}"
+  it "has a valid factory" do
+    expect(FactoryBot.build(:newsletter)).to be_valid
+  end
 end

spec/requests/admin/newsletters_spec.rb

@@ -13,44 +13,43 @@
 # sticking to rails and rspec-rails APIs to keep things simple and stable.
 
 RSpec.describe "/admin/newsletters", type: :request do
-  # This should return the minimal set of attributes required to create a valid
-  # Newsletter. As you add validations to Newsletter, be sure to
-  # adjust the attributes here as well.
-  let(:valid_attributes) {
-    skip("Add a hash of attributes valid for your model")
-  }
-
-  let(:invalid_attributes) {
-    skip("Add a hash of attributes invalid for your model")
-  }
-
-  describe "GET /index" do
+  let(:valid_attributes) { FactoryBot.attributes_for(:newsletter) }
+  let(:invalid_attributes) { {title: "", content: ""} }
+
+  describe "GET /" do
     it "renders a successful response" do
-      Newsletter.create! valid_attributes
-      get admin_newsletters_url
+      FactoryBot.create(:newsletter)
+
+      get admin_newsletters_path
+
       expect(response).to be_successful
     end
   end
 
   describe "GET /show" do
     it "renders a successful response" do
-      newsletter = Newsletter.create! valid_attributes
-      get admin_newsletter_url(newsletter)
+      newsletter = FactoryBot.create(:newsletter)
+
+      get admin_newsletter_path(newsletter)
+
       expect(response).to be_successful
     end
   end
 
   describe "GET /new" do
     it "renders a successful response" do
-      get new_admin_newsletter_url
+      get new_admin_newsletter_path
+
       expect(response).to be_successful
     end
   end
 
   describe "GET /edit" do
     it "renders a successful response" do
-      newsletter = Newsletter.create! valid_attributes
-      get edit_admin_newsletter_url(newsletter)
+      newsletter = FactoryBot.create(:newsletter)
+
+      get edit_admin_newsletter_path(newsletter)
+
       expect(response).to be_successful
     end
   end
@@ -59,72 +58,70 @@
     context "with valid parameters" do
       it "creates a new Newsletter" do
         expect {
-          post admin_newsletters_url, params: {admin_newsletter: valid_attributes}
+          post admin_newsletters_path, params: {newsletter: valid_attributes}
         }.to change(Newsletter, :count).by(1)
       end
 
       it "redirects to the created admin_newsletter" do
-        post admin_newsletters_url, params: {admin_newsletter: valid_attributes}
-        expect(response).to redirect_to(admin_newsletter_url(Newsletter.last))
+        post admin_newsletters_path, params: {newsletter: valid_attributes}
+        expect(response).to redirect_to(admin_newsletter_path(Newsletter.last))
       end
     end
 
     context "with invalid parameters" do
       it "does not create a new Newsletter" do
         expect {
-          post admin_newsletters_url, params: {admin_newsletter: invalid_attributes}
+          post admin_newsletters_path, params: {newsletter: invalid_attributes}
         }.to change(Newsletter, :count).by(0)
       end
 
       it "renders a response with 422 status (i.e. to display the 'new' template)" do
-        post admin_newsletters_url, params: {admin_newsletter: invalid_attributes}
+        post admin_newsletters_path, params: {newsletter: invalid_attributes}
         expect(response).to have_http_status(:unprocessable_entity)
       end
     end
   end
 
   describe "PATCH /update" do
     context "with valid parameters" do
-      let(:new_attributes) {
-        skip("Add a hash of attributes valid for your model")
-      }
+      let(:new_attributes) { {title: "A New Title"} }
 
       it "updates the requested admin_newsletter" do
-        newsletter = Newsletter.create! valid_attributes
-        patch admin_newsletter_url(newsletter), params: {admin_newsletter: new_attributes}
+        newsletter = FactoryBot.create(:newsletter)
+        patch admin_newsletter_path(newsletter), params: {newsletter: new_attributes}
         newsletter.reload
-        skip("Add assertions for updated state")
+        expect(newsletter.title).to eq("A New Title")
       end
 
       it "redirects to the admin_newsletter" do
-        newsletter = Newsletter.create! valid_attributes
-        patch admin_newsletter_url(newsletter), params: {admin_newsletter: new_attributes}
+        newsletter = FactoryBot.create(:newsletter)
+        patch admin_newsletter_path(newsletter), params: {newsletter: new_attributes}
         newsletter.reload
-        expect(response).to redirect_to(admin_newsletter_url(newsletter))
+        expect(response).to redirect_to(admin_newsletter_path(newsletter))
       end
     end
 
     context "with invalid parameters" do
       it "renders a response with 422 status (i.e. to display the 'edit' template)" do
-        newsletter = Newsletter.create! valid_attributes
-        patch admin_newsletter_url(newsletter), params: {admin_newsletter: invalid_attributes}
+        newsletter = FactoryBot.create(:newsletter)
+        patch admin_newsletter_path(newsletter), params: {newsletter: invalid_attributes}
         expect(response).to have_http_status(:unprocessable_entity)
       end
     end
   end
 
   describe "DELETE /destroy" do
     it "destroys the requested admin_newsletter" do
-      newsletter = Newsletter.create! valid_attributes
+      newsletter = FactoryBot.create(:newsletter)
       expect {
-        delete admin_newsletter_url(newsletter)
+        delete admin_newsletter_path(newsletter)
       }.to change(Newsletter, :count).by(-1)
     end
 
     it "redirects to the admin_newsletters list" do
-      newsletter = Newsletter.create! valid_attributes
-      delete admin_newsletter_url(newsletter)
-      expect(response).to redirect_to(admin_newsletters_url)
+      newsletter = FactoryBot.create(:newsletter)
+      delete admin_newsletter_path(newsletter)
+      expect(response).to redirect_to(admin_newsletters_path)
     end
   end
 end