Extract thank yous controller

Author: rossta

app/controllers/concerns/erroring.rb

@@ -1,5 +1,5 @@
 module Erroring
   def not_found!
-    raise ActionController::RoutingError, "Not Found"
+    raise ActionController::RoutingError, "Route not found #{request.path}"
   end
 end

app/controllers/users/registrations_controller.rb

@@ -19,7 +19,7 @@ def create
       NewUserNotifier.deliver_to(AdminUser.all, user: user)
       EmailConfirmationNotifier.deliver_to(user)
 
-      redirect_to thanks_users_registration_path, notice: "Welcome to Joy of Rails! Please check your email for confirmation instructions"
+      redirect_to users_thank_you_path, notice: "Welcome to Joy of Rails! Please check your email for confirmation instructions"
     else
       render Users::Registrations::NewView.new(user: user), status: :unprocessable_entity
     end
@@ -60,10 +60,6 @@ def destroy
     redirect_to root_path, notice: "Your account has been deleted"
   end
 
-  def thanks
-    render Users::Dashboard::IndexView.new
-  end
-
   private
 
   def feature_enabled!

app/controllers/users/thank_yous_controller.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class Users::ThankYousController < ApplicationController
+  def show
+    render Users::ThankYous::ShowView.new
+  end
+end

app/views/users/newsletter_subscriptions/show_view.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 class Users::NewsletterSubscriptions::ShowView < ApplicationView
+  include Phlex::Rails::Helpers::LinkTo
   include Phlex::Rails::Helpers::TurboFrameTag
 
   def initialize(newsletter_subscription:, show_unsubscribe: false)
@@ -31,7 +32,9 @@ def view_template
   end
 
   def subscribed_message
-    plain "You are subscribed to the Joy of Rails newsletter!"
+    link_to("Thank you", users_thank_you_path, class: "font-bold", data: {turbo_frame: "_top"})
+    whitespace
+    plain "for subscribing to the Joy of Rails newsletter!"
     if @newsletter_subscription.subscriber.needs_confirmation?
       whitespace
       plain "Please check your email for a confirmation link."

app/views/users/registrations/thanks_view.rb renamed to app/views/users/thank_yous/show_view.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class Users::Registration::ThanksView < ApplicationView
+class Users::ThankYous::ShowView < ApplicationView
   include Phlex::Rails::Helpers::LinkTo
 
   def view_template
@@ -27,6 +27,10 @@ def view_template
             strong { link_to("articles", "/articles") }
             whitespace
             plain "I’ve written on Ruby, Rails, and Hotwire."
+            if ArticlePage.published.length < 5
+              whitespace
+              plain "I’m working on adding some new content, so check back soon!"
+            end
           end
           li do
             plain "If you’re interested in learning how this app is built or even contributing to it, check out the"

config/routes.rb

@@ -32,12 +32,9 @@
   get "up" => "rails/health#show", :as => :rails_health_check
 
   namespace :users do
+    resource :thank_you, only: [:show]
     resource :header_navigation, only: [:show]
-    resource :registration, only: [:new, :create, :edit, :update, :destroy] do
-      collection do
-        get :thanks
-      end
-    end
+    resource :registration, only: [:new, :create, :edit, :update, :destroy]
     resources :confirmations, only: [:new, :create, :edit, :update], param: :token
     resources :passwords, only: [:new, :create, :edit, :update], param: :token
 

spec/requests/users/registrations_spec.rb

@@ -31,7 +31,7 @@
           params: {user: {email: email, password: "password", password_confirmation: "password"}}
       }.to change(User, :count).by(1)
 
-      expect(response).to redirect_to(thanks_users_registration_path)
+      expect(response).to redirect_to(users_thank_you_path)
       expect(flash[:notice]).to eq("Welcome to Joy of Rails! Please check your email for confirmation instructions")
 
       perform_enqueued_jobs_and_subsequently_enqueued_jobs

spec/system/users/newsletter_subscriptions_spec.rb

@@ -12,11 +12,16 @@
     fill_in "user[email]", with: "[email protected]"
     click_button "Subscribe"
 
-    expect(page).to have_content("You are subscribed to the Joy of Rails newsletter! Please check your email for a confirmation link.")
+    expect(page).to have_content("Thank you for subscribing to the Joy of Rails newsletter! Please check your email for a confirmation link.")
 
     user = User.last
     expect(user.email).to eq("[email protected]")
     expect(user.subscribed_to_newsletter?).to eq(true)
+
+    click_link "Thank you"
+
+    expect(page).to have_content("Welcome to Joy of Rails!")
+    expect(page).to have_content("Thank you for signing up")
   end
 
   it "allows a logged-in user to subscribe to the newsletter" do
@@ -28,7 +33,7 @@
 
     click_button "Subscribe"
 
-    expect(page).to have_content("You are subscribed to the Joy of Rails newsletter! Please check your email for a confirmation link.")
+    expect(page).to have_content("Thank you for subscribing to the Joy of Rails newsletter! Please check your email for a confirmation link.")
 
     expect(user.reload.subscribed_to_newsletter?).to be_truthy