Fix for solid queue error when db pool count mismatched #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solid Queue is configured to have a pool of 4. A change was recently added to error when it detects a mismatch in the DB pool count. rails/solid_queue#457 This change updates config/database.yml to match the Solid Queue default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error after the recent Solid Queue upgrade:
Joy of Rails’ Solid Queue is configured to have a thread pool count of 4 (2 threads for workers + 1 thread for the worker itself + 1 thread for the heartbeat task):
A change was recently added to error when it detects a mismatch in the DB pool count.
rails/solid_queue#457
This change updates config/database.yml to match the Solid Queue default.
A nice improvement would be to make sure Solid Queue can boot in CI.
Pull request checklist
bin/verify