Fix lucene compat tests by keeping asserts disabled

jozala · jozala · commit 0efea20b97cc · 2025-10-07T16:54:56.000+02:00
These asserts have been enabled for the lucene compat because `oldVersion` is now correctly set after elastic#134584 which removed `0.0.0` version.
diff --git a/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/FullClusterRestartDownsampleIT.java b/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/FullClusterRestartDownsampleIT.java
@@ -57,7 +57,7 @@ private static ElasticsearchCluster buildCluster() {
             .apply(() -> clusterConfig)
             .feature(FeatureFlag.TIME_SERIES_MODE);
 
-        if (oldVersion.before(Version.fromString("8.18.0"))) {
+        if (oldVersion.before(Version.fromString("8.18.0")) || isOldClusterDetachedVersion()) {
             cluster.jvmArg("-da:org.elasticsearch.index.mapper.DocumentMapper");
             cluster.jvmArg("-da:org.elasticsearch.index.mapper.MapperService");
         }
diff --git a/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/FullClusterRestartIT.java b/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/FullClusterRestartIT.java
@@ -118,7 +118,7 @@ private static ElasticsearchCluster buildCluster() {
             .apply(() -> clusterConfig)
             .feature(FeatureFlag.TIME_SERIES_MODE);
 
-        if (oldVersion.before(Version.fromString("8.18.0"))) {
+        if (oldVersion.before(Version.fromString("8.18.0")) || isOldClusterDetachedVersion()) {
             cluster.jvmArg("-da:org.elasticsearch.index.mapper.DocumentMapper");
             cluster.jvmArg("-da:org.elasticsearch.index.mapper.MapperService");
         }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ private static ElasticsearchCluster buildCluster() {`
`57`	`57`	`.apply(() -> clusterConfig)`
`58`	`58`	`.feature(FeatureFlag.TIME_SERIES_MODE);`
`59`	`59`
`60`		`- if (oldVersion.before(Version.fromString("8.18.0"))) {`
	`60`	`+ if (oldVersion.before(Version.fromString("8.18.0")) \|\| isOldClusterDetachedVersion()) {`
`61`	`61`	`cluster.jvmArg("-da:org.elasticsearch.index.mapper.DocumentMapper");`
`62`	`62`	`cluster.jvmArg("-da:org.elasticsearch.index.mapper.MapperService");`
`63`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ private static ElasticsearchCluster buildCluster() {`
`118`	`118`	`.apply(() -> clusterConfig)`
`119`	`119`	`.feature(FeatureFlag.TIME_SERIES_MODE);`
`120`	`120`
`121`		`- if (oldVersion.before(Version.fromString("8.18.0"))) {`
	`121`	`+ if (oldVersion.before(Version.fromString("8.18.0")) \|\| isOldClusterDetachedVersion()) {`
`122`	`122`	`cluster.jvmArg("-da:org.elasticsearch.index.mapper.DocumentMapper");`
`123`	`123`	`cluster.jvmArg("-da:org.elasticsearch.index.mapper.MapperService");`
`124`	`124`	`}`