Skip to content

Commit 751a32d

Browse files
Remove Requirement for Key Setting on Azure Client Settings (elastic#82030) (elastic#82039)
We can have a sas token or key for a given client and don't have infrastructure for conditionally checking if either of the two is set so this commit removes the dependency to fix the bug that you can't set these custom settings when using a SAS token. It was somewhat tricky to test this since these validations only run when starting a node as we're dealing with node settings so I just went with a low effort approach and randomly used sas token auth in some ITs which would break without this change. Co-authored-by: Dimitris Rempapis <[email protected]>
1 parent 420343a commit 751a32d

File tree

1 file changed

+1
-1
lines changed
  • server/src/main/java/org/elasticsearch/common/settings

1 file changed

+1
-1
lines changed

server/src/main/java/org/elasticsearch/common/settings/Setting.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -837,7 +837,7 @@ private Stream<String> matchStream(Settings settings) {
837837
* @return the raw list of dependencies for this setting
838838
*/
839839
public Set<AffixSettingDependency> getDependencies() {
840-
return Collections.unmodifiableSet(dependencies);
840+
return dependencies;
841841
}
842842

843843
@Override

0 commit comments

Comments
 (0)