chore: resolve code smells (#545)

Author: jpb06

.github/workflows/ci.yml

@@ -10,10 +10,6 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
-permissions:
-  actions: write
-  contents: read
-
 jobs:
   lint:
     name: ⬣ Lint

pnpm-lock.yaml

@@ -18,12 +18,7 @@ describe('captureErrors function', () => {
     const cause = await effectCause(task);
 
     const result = await Effect.runPromise(
-      pipe(
-        captureErrors(cause, {
-          stripCwd: false,
-        }),
-        Effect.provide(NodeFileSystem.layer),
-      ),
+      pipe(captureErrors(cause, false), Effect.provide(NodeFileSystem.layer)),
     );
 
     expect(result.interrupted).toBe(false);
@@ -60,12 +55,7 @@ describe('captureErrors function', () => {
     const cause = await effectCause(task);
 
     const result = await Effect.runPromise(
-      pipe(
-        captureErrors(cause, {
-          stripCwd: false,
-        }),
-        Effect.provide(NodeFileSystem.layer),
-      ),
+      pipe(captureErrors(cause, false), Effect.provide(NodeFileSystem.layer)),
     );
 
     expect(result.interrupted).toBe(false);
@@ -80,12 +70,7 @@ describe('captureErrors function', () => {
     const cause = await effectCause(Effect.interrupt);
 
     const result = await Effect.runPromise(
-      pipe(
-        captureErrors(cause, {
-          stripCwd: false,
-        }),
-        Effect.provide(NodeFileSystem.layer),
-      ),
+      pipe(captureErrors(cause, false), Effect.provide(NodeFileSystem.layer)),
     );
 
     expect(result).toStrictEqual({

src/capture-errors.test.ts

@@ -27,15 +27,9 @@ export interface CapturedErrors {
   errors: ErrorData[];
 }
 
-export interface CaptureErrorsOptions {
-  stripCwd?: boolean;
-}
-
 export const captureErrors = <E>(
   cause: Cause<E>,
-  options: CaptureErrorsOptions = {
-    stripCwd: true,
-  },
+  stripCwd?: boolean,
 ): Effect.Effect<
   CapturedErrors,
   PlatformError | JsonParsingError,
@@ -50,7 +44,10 @@ export const captureErrors = <E>(
     }
 
     const rawErrors = captureErrorsFrom<E>(cause);
-    const errors = yield* Effect.forEach(rawErrors, transformRawError(options));
+    const errors = yield* Effect.forEach(
+      rawErrors,
+      transformRawError(stripCwd),
+    );
 
     return {
       interrupted: false,

src/capture-errors.ts

@@ -122,7 +122,7 @@ describe('without-spans task', () => {
       expect(raw).not.toContain('Sources 🕵️');
       expect(raw).toContain('Node Stacktrace 🚨');
       expect(message).toMatch(
-        /│ at catcher (.*\/effect-errors\/src\/examples\/without-spans.ts:14:17)/,
+        /│ at catcher (.*\/src\/examples\/without-spans.ts:14:17)/,
       );
     });
   });

src/examples/without-spans.test.ts

@@ -1,5 +1,7 @@
 const cwdRegex =
-  global.process !== undefined ? new RegExp(global.process.cwd(), 'g') : null;
+  globalThis.process === undefined
+    ? null
+    : new RegExp(globalThis.process.cwd(), 'g');
 
 export const stripCwdPath = (path: string): string =>
   cwdRegex === null ? path : path.replace(cwdRegex, '.');